Remove unused Barrier#wait_next functionality #3002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What does this PR do?**: This PR removes the `Barrier#wait_next` functionality which we ended up not making use of. **Motivation**: In #2990 we ran into issues with its current specs, and since we're not using this functionality, it seems like removing it for now seems to be easier than investing more time to fix flakiness in the specs. **Additional Notes**: N/A **How to test the change?**: Existing tests already cover the `Barrier` APIs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
This PR removes the
Barrier#wait_nextfunctionality which we ended up not making use of.Motivation:
In #2990 we ran into issues with its current specs, and since we're not using this functionality, it seems like removing it for now seems to be easier than investing more time to fix flakiness in the specs.
Additional Notes:
N/A
How to test the change?:
Existing tests already cover the
BarrierAPIs.