Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove broken "Test unstable" GitHub action #3064

Merged
merged 2 commits into from
Jun 13, 2024

Commits on Aug 21, 2023

  1. Remove broken "Test unstable" GitHub action

    **What does this PR do?**:
    
    The "Test unstable" GitHub Action runs the dd-trace-rb CI with
    ruby-head and jruby-head.
    
    Because ruby-head and jruby-head aren't always rock solid, we've marked
    these tests with "continue-on-error: true" which in practice means you
    need to actually open them to know if they failed, because they get
    always marked as succeeded.
    
    Today, while looking into our CI config, I noticed these tests have
    been broken for what looks like *months* (due to some refactoring
    in our gemspec):
    
    ```
    [!] There was an error parsing `Gemfile`:
    [!] There was an error while loading `ddtrace.gemspec`: syntax error, unexpected ']', expecting `end' or dummy end - ...ERSION::MAXIMUM_RUBY_VERSION}"]
    ...                              ^
    . Bundler cannot continue.
    
     #  from /home/runner/work/dd-trace-rb/dd-trace-rb/ddtrace.gemspec:10
     #  -------------------------------------------
     #    spec.version               = DDTrace::VERSION::STRING
     >                                  "< #{DDTrace::VERSION::MAXIMUM_RUBY_VERSION}"]
     #    spec.required_rubygems_version = '>= 2.0.0'
     #  -------------------------------------------
    . Bundler cannot continue.
    
     #  from /home/runner/work/dd-trace-rb/dd-trace-rb/Gemfile:3
     #  -------------------------------------------
     #
     >  gemspec
     #
     #  -------------------------------------------
    Error: The process '/home/runner/.rubies/ruby-head/bin/bundle' failed with exit code 14
    ```
    
    (https://github.com/DataDog/dd-trace-rb/actions/runs/5890935813/job/15977021676)
    
    Nobody seems to notice when they fail, and thus it really looks like
    we're not getting any value at all.
    
    Thus, I decided to open a PR to remove them for now.
    
    **Motivation**:
    
    As our CI gets more complex, we get little value from things that
    need to be checked manually -- nowadays we have hundreds of
    validations.
    
    **Additional Notes**:
    
    N/A
    
    **How to test the change?**:
    
    Validate that CI is still green, and this action no longer runs.
    ivoanjo committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    91c884c View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2024

  1. Configuration menu
    Copy the full SHA
    b8c91f0 View commit details
    Browse the repository at this point in the history