Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport ffi changes #3682

Merged
merged 4 commits into from
Jun 5, 2024
Merged

backport ffi changes #3682

merged 4 commits into from
Jun 5, 2024

Conversation

TonyCTHsu
Copy link
Contributor

@TonyCTHsu TonyCTHsu commented Jun 5, 2024 •
edited
Loading

Backport #3680

@github-actions github-actions bot added appsec Application Security monitoring product core Involves Datadog core libraries integrations Involves tracing integrations profiling Involves Datadog profiling single-step Single Step APM Instrumentation labels Jun 5, 2024
@TonyCTHsu TonyCTHsu changed the base branch from master to 1.x-stable June 5, 2024 11:40
@TonyCTHsu TonyCTHsu added this to the 1.23.1 milestone Jun 5, 2024
@TonyCTHsu TonyCTHsu force-pushed the tonycthsu/backkport-ffi-changes branch from 63157ad to 581803d Compare June 5, 2024 11:46
@github-actions github-actions bot removed core Involves Datadog core libraries appsec Application Security monitoring product profiling Involves Datadog profiling integrations Involves tracing integrations labels Jun 5, 2024
@TonyCTHsu TonyCTHsu added the dev/internal Other internal work that does not need to be included in the changelog label Jun 5, 2024
@TonyCTHsu TonyCTHsu marked this pull request as ready for review June 5, 2024 15:05
@TonyCTHsu TonyCTHsu requested a review from a team as a code owner June 5, 2024 15:05
@TonyCTHsu TonyCTHsu changed the title backkport ffi changes backport ffi changes Jun 5, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.24%. Comparing base (e9dcf8e) to head (4fabb4c).

Additional details and impacted files 
@@             Coverage Diff             @@
##           1.x-stable    #3682   +/-   ##
===========================================
  Coverage       98.24%   98.24%           
===========================================
  Files            1255     1255           
  Lines           74655    74655           
  Branches         3548     3548           
===========================================
  Hits            73347    73347           
  Misses           1308     1308

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TonyCTHsu TonyCTHsu enabled auto-merge June 5, 2024 15:31
ivoanjo
ivoanjo approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

I was a bit a bit confused at the start, I think you forgot to mention that you also backported #3681 (not just #3680) but otherwise the changes look reasonable.

@TonyCTHsu TonyCTHsu merged commit f069f6d into 1.x-stable Jun 5, 2024
195 checks passed
@TonyCTHsu TonyCTHsu deleted the tonycthsu/backkport-ffi-changes branch June 5, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivoanjo ivoanjo ivoanjo approved these changes

Assignees
No one assigned
Labels
dev/internal Other internal work that does not need to be included in the changelog single-step Single Step APM Instrumentation
Projects
None yet
Milestone
1.23.1
Development

Successfully merging this pull request may close these issues.
3 participants
@TonyCTHsu @codecov-commenter @ivoanjo