Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use unified Gitlab pipeline for APM libraries #3800

Merged
merged 31 commits into from
Jul 26, 2024
Merged

Conversation

randomanderson
Copy link
Contributor

What does this PR do?

  1. Converts the Gitlab workflow to use the unified pipeline.
  2. Changes kubernetes library injection to work similar to how host injection works. Previously for k8s injection, dependencies were downloaded at runtime.

Motivation:

  1. By using the unified pipeline across all APM libraries, there is less maintenance hassle, fewer mistakes, and a more uniform creation of artifacts.
  2. Downloading dependencies at runtime is slow. Additionally some network policies do not allow pods to connect to the open internet which would prevent injection from succeeding.

How to test the change?
The changes were tested manually. CI/CD workflows are notoriously hard to test. Final products (OCI image and lib-init image) were run through automated onboarding tests.

@randomanderson randomanderson added dev/ci Involves CircleCI, GitHub Actions, or GitLab single-step Single Step APM Instrumentation labels Jul 22, 2024
@randomanderson randomanderson requested review from a team as code owners July 22, 2024 13:47
lib-injection/host_inject.rb Outdated Show resolved Hide resolved
lib-injection/host_inject.rb Outdated Show resolved Hide resolved
lib-injection/host_inject.rb Outdated Show resolved Hide resolved
lib-injection/host_inject.rb Outdated Show resolved Hide resolved
lib-injection/host_inject.rb Outdated Show resolved Hide resolved
lib-injection/host_inject.rb Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the dev/ci Involves CircleCI, GitHub Actions, or GitLab label Jul 22, 2024
@randomanderson randomanderson changed the title Landerson/one pipeline Use unified Gitlab pipeline for APM libraries Jul 22, 2024
@pr-commenter
Copy link

pr-commenter bot commented Jul 22, 2024

Benchmarks

Benchmark execution time: 2024-07-26 14:32:23

Comparing candidate commit 93bb3d6 in PR branch landerson/one-pipeline with baseline commit 3c46876 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics.

@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.90%. Comparing base (3c46876) to head (93bb3d6).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3800      +/-   ##
==========================================
- Coverage   97.90%   97.90%   -0.01%     
==========================================
  Files        1261     1261              
  Lines       75620    75620              
  Branches     3706     3706              
==========================================
- Hits        74039    74035       -4     
- Misses       1581     1585       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TonyCTHsu TonyCTHsu merged commit f72d19f into master Jul 26, 2024
181 checks passed
@TonyCTHsu TonyCTHsu deleted the landerson/one-pipeline branch July 26, 2024 19:18
@github-actions github-actions bot added this to the 2.3.0 milestone Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
single-step Single Step APM Instrumentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants