[PROF-10198] Set service/env for GitLab runs in benchmark platform #3802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What does this PR do?** This PR sets the `DD_SERVICE` and `DD_ENV` for the gitlab benchmark in the benchmarking platform. **Motivation:** While testing a few changes, I realized these benchmarks were running with no name, thus ending up with `gitlab-runner` which is not a very clear name (and makes it hard to know what it is). To align with the reliability environment (`rp-ruby-gitlab`) I've explicitly set a matching name. **Additional Notes:** N/A **How to test the change?** I've tested this with the `bp-runner`.
BenchmarksBenchmark execution time: 2024-07-23 12:19:33 Comparing candidate commit 8d6b00a in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3802 +/- ##
=======================================
Coverage 97.91% 97.92%
=======================================
Files 1248 1248
Lines 75315 75315
Branches 3644 3644
=======================================
+ Hits 73746 73749 +3
+ Misses 1569 1566 -3 ☔ View full report in Codecov by Sentry. |
marcotc
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR sets the
DD_SERVICEandDD_ENVfor the gitlab benchmark in the benchmarking platform.Motivation:
While testing a few changes, I realized these benchmarks were running with no name, thus ending up with
gitlab-runnerwhich is not a very clear name (and makes it hard to know what it is).To align with the reliability environment (
rp-ruby-gitlab) I've explicitly set a matching name.Additional Notes:
N/A
How to test the change?
I've tested this with the
bp-runner: