Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PROF-10275] Enable crashtracking telemetry by default when profiler is enabled #3816

Merged
merged 1 commit into from
Aug 1, 2024

Commits on Jul 31, 2024

  1. [PROF-10275] Enable crashtracking telemetry by default when profiler …

    …is enabled
    
    **What does this PR do?**
    
    This PR enables the crashtracking telemetry feature by default when the
    profiler is enabled.
    
    This feature can be disabled using the
    `DD_PROFILING_EXPERIMENTAL_CRASH_TRACKING_ENABLED` environment variable
    or the `c.profiling.advanced.experimental_crash_tracking_enabled`
    setting via code.
    
    This setting is not very well-named, as the feature is no longer
    experimental. But as we're actually considering separating crashtracking
    from profiling, I decided to leave the current setting in place until we
    can decide where this is going to live, since that's going to influence
    where the new setting without "experimental" on its name should land.
    
    **Motivation:**
    
    Crashtracking allows us to identify issues that may otherwise go
    unnoticed. We've been deploying it on other Datadog libraries with great
    success so far.
    
    **Additional Notes:**
    
    We've had configurations running with crashtracking enabled on our usual
    validation environments + almost all (1 remaining!) internal Ruby apps
    also has been running with this feature.
    
    We've not seen any noticeable impact for enabling this feature.
    
    In fact, now that it's going to be the default, I'll go ahead and remove
    the separate configurations we had for testing it.
    
    **How to test the change?**
    
    The following snippet starts a Ruby instance with profiling, and crashes
    it immediately:
    
    ```bash
    DD_PROFILING_ENABLED=true bundle exec ddprofrb exec ruby -e 'Process.kill("SEGV", Process.pid)'
    ```
    
    You should see an error report submitted to the agent.
    ivoanjo committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    c686714 View commit details
    Browse the repository at this point in the history