DEBUG-2657 prefix benchmark names with the product as per their source file #3828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-datadog
force-pushed
the
benchmark-dry-2
branch
from
1d08d50
to
52967e5
Compare
ivoanjo
reviewed
Aug 7, 2024
benchmarks/benchmarks_helper.rb
Outdated
Comment on lines
5
to
15
| module JobReporter | ||
| def report(name, *args, **opts, &block) | ||
| caller_path = caller_locations.first.path | ||
| prefix = File.basename(caller_path).sub(/_.*\z/, '') | ||
| super("#{prefix} - #{name}", *args, **opts, &block) | ||
| end | ||
| end | ||
|
|
||
| class Benchmark::IPS::Job | ||
| prepend JobReporter | ||
| end |
There was a problem hiding this comment.
This seems to be breaking (older?) versions of benchmark/ips (on older Rubies)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3828 +/- ##
=======================================
Coverage 97.83% 97.83%
=======================================
Files 1264 1264
Lines 75678 75678
Branches 3720 3720
=======================================
+ Hits 74039 74042 +3
+ Misses 1639 1636 -3 ☔ View full report in Codecov by Sentry. |
p-datadog
force-pushed
the
benchmark-dry-2
branch
from
bbfe1cb
to
d8b13dd
Compare
p-datadog
force-pushed
the
benchmark-dry-2
branch
from
d8b13dd
to
b37f157
Compare
|
List of benchmarks looks like this now:
|
* master: Suppress startup logs in test and development environments [PROF-10241] Fix issue in tests by simplifying `at_fork` monkey patch Minor: Check pid before hash Rename ProcessDaemonMonkeyPatch -> ProcessMonkeyPatch [PROF-10241] Use Process._fork hook in `at_fork` monkey patch on Ruby 3.1+ Minor: Bootstrap empty rbs file Rubocop fixes Update Steepfile Add note about not re-registering the same block [PROF-10241] Extract profiler `at_fork` monkey patch to utils Remove typechecking skeleton Rename `Kernel` monkey patch to `KernelMonkeyPatch` to avoid confusion Rename `at_fork` -> `datadog_at_fork` to avoid any clashes Minor: Avoid returning process after monkey patching Rename ProcessDaemonPatch -> ProcessDaemonMonkeyPatch Clean up test skipping to not depend on profiling Minor: Clean up storage initialization + don't leak storage Quick pass at cleaning up/refreshing comments
p-datadog
pushed a commit
to p-datadog/dd-trace-rb
that referenced
this pull request
Aug 12, 2024
* master: (31 commits) DEBUG-2657 prefix benchmark names with the product as per their source file (DataDog#3828) [NO-TICKET] Don't put results in benchmarking folder directly Suppress startup logs in test and development environments [PROF-10241] Fix issue in tests by simplifying `at_fork` monkey patch Minor: Check pid before hash Rename ProcessDaemonMonkeyPatch -> ProcessMonkeyPatch [PROF-10241] Use Process._fork hook in `at_fork` monkey patch on Ruby 3.1+ Minor: Bootstrap empty rbs file Rubocop fixes Update Steepfile Add note about not re-registering the same block [PROF-10241] Extract profiler `at_fork` monkey patch to utils Remove typechecking skeleton Rename `Kernel` monkey patch to `KernelMonkeyPatch` to avoid confusion Rename `at_fork` -> `datadog_at_fork` to avoid any clashes Minor: Avoid returning process after monkey patching Rename ProcessDaemonPatch -> ProcessDaemonMonkeyPatch Clean up test skipping to not depend on profiling Minor: Clean up storage initialization + don't leak storage Quick pass at cleaning up/refreshing comments ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Prefixes each benchmark name with the product prefix.
Motivation:
At 37 current benchmarks, their list is awkward to look through. The prefix will make benchmarks grouped by product which will make them easier to read.
Additional Notes:
How to test the change?
Benchmark platform UI
Unsure? Have a question? Request a review!