DEBUG-2334 Probe Builder for dynamic instrumentation #3921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-datadog
force-pushed
the
di-probe-builder
branch
from
ad924de
to
e36703c
Compare
p-datadog
force-pushed
the
di-probe-builder
branch
from
e36703c
to
682bbb9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3921 +/- ##
=======================================
Coverage 97.86% 97.86%
=======================================
Files 1288 1290 +2
Lines 77109 77180 +71
Branches 3803 3808 +5
=======================================
+ Hits 75462 75535 +73
+ Misses 1647 1645 -2 ☔ View full report in Codecov by Sentry. |
marcotc
approved these changes
Sep 20, 2024
p-datadog
pushed a commit
to p-datadog/dd-trace-rb
that referenced
this pull request
Sep 23, 2024
* master: (122 commits) DEBUG-2334 Probe Builder for dynamic instrumentation (DataDog#3921) Fix matrix format Remove GraphQL error test that provides low value Add missing GraphQL and Hanami tests to CI Exclude linter Skip JRuby which does not respond to fork Add backtrace Add SSI entry point Remove before merge Update PR body Use PAT [PROF-10422] Fix flaky GVL profiling integration spec [🤖] Update Latest Dependency: https://github.com/DataDog/dd-trace-rb/actions/runs/10958098108 [NO-TICKET] Fix flaky spec in profiler due to race Remove obsolete group [🤖] Lock Dependency: https://github.com/DataDog/dd-trace-rb/actions/runs/10956486485 Remove obsolete task Raise ArgumentError when trying to use GVL profiling on unsupported Rubies Update gemfiles/* Cleanup gemfile ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds
ProbeBuilderclass which parses remote configuration payloads intoProbeconstructor arguments.Motivation:
Initial implementation of dynamic instrumentation for Ruby.
Additional Notes:
How to test the change?
Unit tests.
Unsure? Have a question? Request a review!