Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump paperplane #5093

Merged
merged 3 commits into from
Aug 1, 2019
Merged

Bump paperplane #5093

merged 3 commits into from
Aug 1, 2019

Conversation

flintinatux
Copy link
Contributor

What does this PR do?

This PR adds a listing for paperplane log injection.

Motivation

I have submitted this PR to add paperplane log injection, and wanted to include it in the docs when it ships.

Preview link

Since this PR is from a fork, I guess this is best way to preview:

https://github.com/articulate/documentation/blob/bb3c1bef0910ea70662fa1ad0e81028902727ae3/content/en/tracing/setup/nodejs.md

https://github.com/articulate/documentation/blob/bb3c1bef0910ea70662fa1ad0e81028902727ae3/content/fr/tracing/setup/nodejs.md

Additional Notes

@flintinatux flintinatux requested a review from a team as a code owner July 29, 2019 15:32
@l0k0ms l0k0ms added the Tracing label Jul 30, 2019
@l0k0ms l0k0ms added the Do Not Merge Just do not merge this PR :) label Jul 30, 2019
@l0k0ms
Copy link
Contributor

l0k0ms commented Jul 30, 2019

Many thanks for your PR 🙇

We are just going to wait for the next release of dd-trace-js before merging this.

@rochdev rochdev removed the Do Not Merge Just do not merge this PR :) label Jul 31, 2019
@rochdev
Copy link
Member

rochdev commented Jul 31, 2019

@l0k0ms 0.14.0 has been released, so we can merge this.

Copy link
Contributor

@l0k0ms l0k0ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@l0k0ms l0k0ms merged commit 1e682d0 into DataDog:master Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants