Ignore nil tags and convert symbol ones

[pschambacher]

@degemer

When upgrading to version 3.0, we got a couple errors. In previous versions (at least v1), you could pass nil tags that would be ignored and symbol tags that would be converted to strings.

This brings the functionality back.

[pschambacher]

I can make this tag = tag.to_s if tag.is_a?(Symbol) to avoid stupid cases like numbers or complex objects

[degemer]

I don't think we need to check for those, the documentation clearly specifies that tags should be an array of strings. I'm ok with supporting tags because it used to work with 1.x and the change is small, but people reading the documentation will/should likely use strings.

Actually, I think this change is not needed with #51.

[degemer]

Thanks for the contribution!

I left a small comment, LGTM apart from that.

[degemer]

I don't think we need to check for those, the documentation clearly specifies that tags should be an array of strings. I'm ok with supporting tags because it used to work with 1.x and the change is small, but people reading the documentation will/should likely use strings.

Actually, I think this change is not needed with #51.

[mikhailov]

@degemer
but people reading the documentation will/should likely use strings.

well, we do read documentation, but there is a breaking change that slows down from upgrade applications to the 3.*. However the major version bump perfectly fits to introduce breaking change, so either option would be great to implement:

1. make the gem backward compatible by merging this PR or Ignore nil tags and convert symbol ones #53
2. make a configuration option that typecast tags
3. make a step-by-step guideline to bump the gem, despite of existed documentation there is no effortless way to upgrade it at the moment.

what you think?

[zippolyte]

Hi @pschambacher, I'm going to merge this, thanks for your contribution

[pschambacher]

🙇