Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use defaults when host/port are nil #56

Merged
merged 5 commits into from
Nov 15, 2017
Merged

Use defaults when host/port are nil #56

merged 5 commits into from
Nov 15, 2017

Conversation

degemer
Copy link
Member

@degemer degemer commented Jul 14, 2017

As we used to do it, was broken by 3.0.

See #54

@degemer
Use defaults when host/port are nil
1ee2a5f 
As we used to do it, was broken by 3.0.
@degemer degemer added this to the 3.1.0 milestone Jul 14, 2017
@degemer degemer assigned yannmh and unassigned yannmh Jul 14, 2017
@degemer degemer requested a review from yannmh July 14, 2017 12:40
@masci masci merged commit e35e09d into master Nov 15, 2017
@masci masci deleted the quentin/defaults branch November 15, 2017 21:06
@masci masci mentioned this pull request Nov 15, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yannmh yannmh Awaiting requested review from yannmh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@degemer @masci @yannmh