reduce object allocation and make all strings frozen on ruby 2.3+ #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grosser
force-pushed
the
grosser/freeze
branch
2 times, most recently
from
0903d3f
to
855f492
Compare
|
need the coverage PR merged too or this will be a red build |
|
ready for merge! |
gmmeyer
approved these changes
May 24, 2018
|
@grosser go ahead and rebase! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is slightly more dangerous on ruby 2.3+ since it makes all internal strings frozen ... and they might blow up in untested edge-cases, so maybe get 3.3 out and leave it for 3.4 ...
as a bonus feature this also makes sure we never modify options hash that is passed in
@masci
Failing test will look like this:
