Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port / host / tags / namespace can no longer be set on the instance t… #87

Merged
merged 1 commit into from
May 31, 2018
Merged

port / host / tags / namespace can no longer be set on the instance t… #87

merged 1 commit into from
May 31, 2018

Conversation

grosser
Copy link
Contributor

@grosser grosser commented May 24, 2018

…o allow thread-safety

should make #85 a lot simpler

@johvet @gmmeyer @masci

gmmeyer
gmmeyer approved these changes May 31, 2018
View reviewed changes
Copy link
Contributor

@gmmeyer gmmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This simplifies a lot! Thanks

@gmmeyer gmmeyer merged commit 79036c7 into DataDog:master May 31, 2018
@masci masci added this to the 4.0.0 milestone Aug 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmmeyer gmmeyer gmmeyer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@grosser @gmmeyer @masci