Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make format_service_check private #89

Merged
merged 1 commit into from
Jun 6, 2018
Merged

make format_service_check private #89

merged 1 commit into from
Jun 6, 2018

Conversation

grosser
Copy link
Contributor

@grosser grosser commented May 31, 2018

@grosser
Copy link
Contributor Author

grosser commented Jun 5, 2018

@gmmeyer need more reviews! :)

gmmeyer
gmmeyer approved these changes Jun 6, 2018
View reviewed changes
Copy link
Contributor

@gmmeyer gmmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

easy change, looks good

@gmmeyer
Copy link
Contributor

gmmeyer commented Jun 6, 2018

can you rebase? :)

@grosser
Copy link
Contributor Author

grosser commented Jun 6, 2018

done

@gmmeyer gmmeyer merged commit 2d05082 into DataDog:master Jun 6, 2018
@masci masci added this to the 4.0.0 milestone Aug 20, 2018
pudiva pushed a commit to pudiva/dogstatsd-ruby that referenced this pull request Jun 5, 2023
@mclark
Merge pull request DataDog#89 from github/workflow
f5aaaf2 
Add workflow diagrams to README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmmeyer gmmeyer gmmeyer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@grosser @gmmeyer @masci