Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fail fast on unknown options #93

Merged
merged 2 commits into from
Jun 7, 2018
Merged

Conversation

grosser
Copy link
Contributor

@grosser grosser commented Jun 1, 2018

prevents typos and makes the initializer easier to read + less hash lookups ... might do that for more methods later

needs ruby 2.0+ ... 1.9 was "end of life" February 23, 2015 ... and whoever still runs it will get an old version since it requires 2.0+

@grosser
Copy link
Contributor Author

grosser commented Jun 1, 2018

@gmmeyer

@gmmeyer
Copy link
Contributor

gmmeyer commented Jun 6, 2018

@grosser can you address the rubocop failures?

@grosser
Copy link
Contributor Author

grosser commented Jun 6, 2018

fixed ... turned out rubocop was linting for 1.9 which did not have keyword args :)
... also changed rake to run rubocop so users see failures before making PRs

@grosser
Copy link
Contributor Author

grosser commented Jun 6, 2018

ready!

@grosser
Copy link
Contributor Author

grosser commented Jun 7, 2018

@gmmeyer merge ?

@grosser grosser mentioned this pull request Jun 7, 2018
@gmmeyer gmmeyer merged commit 8459020 into DataDog:master Jun 7, 2018
@masci masci added this to the 4.0.0 milestone Aug 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants