Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting kubernetesResourcesLabelsAsTags brakes helm templating since 3.73.1 #1631

Closed
alexstojda opened this issue Dec 11, 2024 · 2 comments
Closed

Comments

@alexstojda
Copy link

alexstojda commented Dec 11, 2024

Since agent chart version 3.73.1 helm templating fails when setting datadog.kubernetesResourcesLabelsAsTags.

Pretty sure the issue stems from this commit 0802799 by @gabedos

How to reproduce

Run helm template datadog datadog/datadog with values:

datadog:
  kubernetesResourcesLabelsAsTags:
    '*': 'kube_%%label%%'
    'labels.mycompany.com/foo': 'bar'

You should get an error:

Error: YAML parse error on datadog/templates/cluster-agent-rbac.yaml: error converting YAML to JSON: yaml: line 19: did not find expected alphabetic or numeric character
@gabedos
Copy link
Contributor

gabedos commented Dec 12, 2024

Hello @alexstojda, you should be able to use datadog.kubernetesResourcesLabelsAsTags with the following configuration.

kubernetesResourcesLabelsAsTags:
    pods:
      "*": "kube_%%label%%"

This original PR should provide more context, particularly in the helm-charts/charts/datadog/values.yaml file providing examples to configure this value.

Hope this helps!

@alexstojda
Copy link
Author

Ah, this is kind of a breaking change, would have been useful to mention that in the changelog too 😅

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants