Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis sentinel integration needs an update because of removed SLAVES command #1586

Open
Akkowicz opened this issue Oct 31, 2022 · 3 comments

Comments

@Akkowicz
Copy link

Output of the info page

    redis_sentinel (1.1.0)
    ----------------------
      Instance ID: redis_sentinel:90bad44364c7949d [WARNING]
      Configuration Source: file:/etc/datadog-agent/conf.d/redis_sentinel.d/conf.yaml
      Total Runs: 33
      Metric Samples: Last Run: 3, Total: 99
      Events: Last Run: 0, Total: 0
      Service Checks: Last Run: 2, Total: 66
      Average Execution Time : 1ms
      Last Execution Date : 2022-10-31 10:00:54 CET / 2022-10-31 09:00:54 UTC (1667206854000)
      Last Successful Execution Date : 2022-10-31 10:00:54 CET / 2022-10-31 09:00:54 UTC (1667206854000)

      Warning: Error collecting metrics for master jd-redis-production-1: unknown subcommand 'SLAVES'. Try SENTINEL HELP.

Additional environment details (Operating System, Cloud provider, etc):
Ubuntu 20.04.5 LTS, dedicated server, Redis 7.0.0 + redis stack installed

Steps to reproduce the issue:

  1. Install redis_sentinel integration, version 1.1.0
  2. Configure it for your redis sentinel
  3. It fails to send any data due to removed slaves command

Describe the results you received:
No data sent to datadog

Describe the results you expected:
Integration data sent to datadog

Additional information you deem important (e.g. issue happens only occasionally):

Redis changed commands from SLAVES to REPLICAS:
https://redis.io/docs/manual/sentinel/#sentinel-commands

@FlorentClarret
Copy link
Member

Hi, thanks for opening this issue. Pinging @krasnoukhov as maintainer of the Redis Sentinel integration.

@krasnoukhov
Copy link
Collaborator

Unfortunately we don't use this integration any longer (moved to ElastiCache). Any chance someone else would be interested in taking over?

@FlorentClarret
Copy link
Member

Unfortunately we don't use this integration any longer (moved to ElastiCache). Any chance someone else would be interested in taking over?

I understand. I opened a PR to update the codeowners accordingly.

@Akkowicz We will try to take a look at the issue but I can't tell you when exactly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants