Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filebeat using deprecated AgentCheck.increment and .decrement functions #568

Open
shcallaway opened this issue Mar 24, 2020 · 2 comments
Open
Assignees

Comments

@shcallaway
Copy link

shcallaway commented Mar 24, 2020

Output of the info page

$ k exec -ti datadog-agent-snsfn bash
root@datadog-agent-snsfn:/# s6-svstat /var/run/s6/services/agent/
up (pid 349) 143 seconds

Additional environment details (Operating System, Cloud provider, etc):

AWS EKS

Steps to reproduce the issue:

  1. Install the Filebeat check in Datadog agent pod in Kubenretes
  2. Register Filebeat check by adding Datadog autodiscovery annotations to Filebeat pod
  3. Stream logs of Datadog agent pod

Describe the results you received:

Filebeat integration prints the following deprecation notice:

datadog-agent 2020-03-24 19:43:53 UTC | CORE | WARN | (pkg/collector/python/datadog_agent.go:118 in LogMessage) | filebeat:e00f8fb4ebe0e9e6 | (base.py:536) | DEPRECATION NOTICE: `AgentCheck.increment`/`AgentCheck.decrement` are deprecated, please use `AgentCheck.gauge` or `AgentCheck.count` instead, with a different metric name

Describe the results you expected:

The Filebeat integration should be migrated to use the newer gauge and count functions, as there may be issues with continued use of increment and decrement.

Additional information you deem important (e.g. issue happens only occasionally):

@hithwen
Copy link
Contributor

hithwen commented Mar 26, 2020

Hallo @shcallaway, integrations in this repo are community maintained. I can ping @wk8 as filebeat codeowner about this but code contributions are welcome too.

@yzhan289
Copy link
Contributor

Checking in on this, @wk8 have you had a chance to look at this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants