Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ddtelemetry generated cbindgen headers #138

Merged
merged 3 commits into from
Apr 24, 2023

Conversation

paullegranddc
Copy link
Contributor

@paullegranddc paullegranddc commented Apr 21, 2023

What does this PR do?

  • Add ipc crate to cbindgen config
  • PlatformHandle and NativeUnixStream are not ABI stable, thus not repr-C-able since it contains an Arc cell

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

How to test the change?

Describe here in detail how the change can be validated.

* PlatformHandle is not ABI stable since it contains an Arc cell
@paullegranddc paullegranddc marked this pull request as ready for review April 21, 2023 13:05
@paullegranddc paullegranddc requested a review from a team as a code owner April 21, 2023 13:05
@pawelchcki pawelchcki merged commit 9178344 into main Apr 24, 2023
@bantonsson bantonsson deleted the paullgdc/fix_ddtrelemetry_cbindgen branch March 7, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants