Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix env_verifier + protobuf gitlab build issues #148

Merged
merged 3 commits into from
May 2, 2023

Conversation

thedavl
Copy link
Contributor

@thedavl thedavl commented May 2, 2023

What does this PR do?

Fixed env_verifier unit test + protobuf gitlab build issues (failing on windows/centos static analysis)

Motivation

build failures

Additional Notes

Anything else we should know when reviewing?

How to test the change?

Describe here in detail how the change can be validated.

@thedavl thedavl marked this pull request as ready for review May 2, 2023 15:28
@thedavl thedavl requested review from a team as code owners May 2, 2023 15:28
Copy link
Contributor

@gleocadie gleocadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
The current windows static analysis job is broken, I ran this branch on my local windows machine and it fixes the current issue.
There are other issues but not related to this (will be fixed later)

Copy link

@maxday maxday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, how does it impact the binary size?

@thedavl
Copy link
Contributor Author

thedavl commented May 2, 2023

LGTM, how does it impact the binary size?

No change in binary size!

@thedavl thedavl merged commit 812cd40 into main May 2, 2023
@thedavl thedavl deleted the david.lee/fix-build-issues branch May 2, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants