Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report downstream gitlab pipeline failures to github #159

Merged
merged 2 commits into from
May 31, 2023

Conversation

nsavoire
Copy link
Contributor

What does this PR do?

It seems that since there are no "real" jobs in gitlab pipeline, only a trigger for a downstream pipeline, gitsync does not push any status check to github (status checks are associated to "real" jobs). The workaround it to create an actual job whose status depends on status of downstream pipeline.

@nsavoire nsavoire requested a review from a team as a code owner May 16, 2023 15:07
ivoanjo
ivoanjo previously approved these changes May 17, 2023
Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable!

I see a "dd-gitlab/report_gitlab_CI_status" that's marked as passed on this PR, so the mechanism seems to be working fine.

Here sir, take my 👍.

.gitlab-ci.yml Outdated Show resolved Hide resolved
nsavoire and others added 2 commits May 31, 2023 10:59
It seems that since there are no "real" jobs in gitlab pipeline, only
a trigger for a downstream pipeline, gitsync does not push any status
check to github (status checks are associated to "real" jobs).
The workaround it to create an actual job whose status depends on
status of downstream pipeline.
Co-authored-by: Ivo Anjo <ivo.anjo@datadoghq.com>
Copy link
Contributor

@r1viollet r1viollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks for looking into this!

@nsavoire nsavoire merged commit 9e4ea80 into main May 31, 2023
@nsavoire nsavoire deleted the nsavoire/report_failure branch May 31, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants