Allow verify trace-protobuf to continue on error, try 2 #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What does this PR do?** In #275, I've attempted to add the `mainmatter/continue-on-error-comment` github action which replaces a CI error with a comment, so that it's less annoying when "Verify trace-protobuf" fails and we don't get a ugly red cross on every PR. My first attempt didn't work! I missed that I needed to change the trigger for the verify action to be on pull requests, not on pushes. This PR fixes that, and we should see the action comment show up as an example. **Motivation:** Fix #275. **Additional Notes:** N/A **How to test the change?** See the comment that will show up!
|
Some tests with 'continue-on-error: true' have failed:
Created by continue-on-error-comment |
This was referenced Oct 27, 2023
morrisonlevi
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In #275, I've attempted to add the
mainmatter/continue-on-error-commentgithub action which replaces a CI error with a comment, so that it's less annoying when "Verify trace-protobuf" fails and we don't get a ugly red cross on every PR.My first attempt didn't work! I missed that I needed to change the trigger for the verify action to be on pull requests, not on pushes.
This PR fixes that, and we should see the action comment show up as an example.
Motivation
Fix #275.
Additional Notes
N/A
How to test the change?
See the comment that will show up!
For Reviewers
@DataDog/security-design-and-guidance.