Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow verify trace-protobuf to continue on error, try 2 #280

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Allow verify trace-protobuf to continue on error, try 2 #280

merged 1 commit into from
Nov 1, 2023

Commits on Oct 27, 2023

  1. Allow verify trace-protobuf to continue on error, try 2 

    **What does this PR do?**

In #275, I've attempted to add the
`mainmatter/continue-on-error-comment` github action which replaces a CI
error with a comment, so that it's less annoying when
"Verify trace-protobuf" fails and we don't get a ugly red cross on every
PR.

My first attempt didn't work! I missed that I needed to change the
trigger for the verify action to be on pull requests, not on pushes.

This PR fixes that, and we should see the action comment show up
as an example.

**Motivation:**

Fix #275.

**Additional Notes:**

N/A

**How to test the change?**

See the comment that will show up!
    @ivoanjo
    ivoanjo committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    4b5573f View commit details
    Browse the repository at this point in the history