Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run clippy on windows in CI #485

Merged
merged 4 commits into from
Jun 14, 2024

Conversation

VianneyRuhlmann
Copy link
Contributor

@VianneyRuhlmann VianneyRuhlmann commented Jun 13, 2024

What does this PR do?

Run clippy on windows, it is currently done in gitlab. This allows us to remove the gitlab job to run clippy only once.

Motivation

We need to run clippy on windows to check windows specific code

@ivoanjo
Copy link
Member

ivoanjo commented Jun 13, 2024

"Clippy is home" ;)

@VianneyRuhlmann VianneyRuhlmann force-pushed the vianney/actions/run-clippy-on-windows branch from 0fda14b to ce45832 Compare June 13, 2024 13:14
@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.67%. Comparing base (6fcf188) to head (ffcea0b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #485   +/-   ##
=======================================
  Coverage   69.67%   69.67%           
=======================================
  Files         199      199           
  Lines       26606    26606           
=======================================
  Hits        18539    18539           
  Misses       8067     8067           
Components Coverage Δ
crashtracker 17.46% <ø> (ø)
datadog-alloc 98.76% <ø> (ø)
data-pipeline 51.30% <ø> (ø)
data-pipeline-ffi 0.00% <ø> (ø)
ddcommon 85.97% <ø> (ø)
ddcommon-ffi 74.15% <ø> (ø)
ddtelemetry 56.37% <ø> (ø)
ipc 84.66% <ø> (ø)
profiling 79.13% <ø> (ø)
profiling-ffi 59.53% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 36.26% <ø> (ø)
sidecar-ffi 0.00% <ø> (ø)
spawn-worker 54.98% <ø> (ø)
trace-mini-agent 69.36% <ø> (ø)
trace-normalization 97.79% <ø> (ø)
trace-obfuscation 95.73% <ø> (ø)
trace-protobuf 24.52% <ø> (ø)
trace-utils 90.79% <ø> (ø)

@VianneyRuhlmann VianneyRuhlmann force-pushed the vianney/actions/run-clippy-on-windows branch 2 times, most recently from 28837c6 to 015bf2b Compare June 13, 2024 13:22
@VianneyRuhlmann VianneyRuhlmann marked this pull request as ready for review June 13, 2024 14:45
@VianneyRuhlmann VianneyRuhlmann requested a review from a team as a code owner June 13, 2024 14:45
@VianneyRuhlmann VianneyRuhlmann force-pushed the vianney/actions/run-clippy-on-windows branch from 83eb562 to 9e23d45 Compare June 14, 2024 07:51
@VianneyRuhlmann VianneyRuhlmann requested a review from a team as a code owner June 14, 2024 08:24
@github-actions github-actions bot added the profiling Relates to the profiling* modules. label Jun 14, 2024
@VianneyRuhlmann VianneyRuhlmann force-pushed the vianney/actions/run-clippy-on-windows branch from 813ba2b to ffcea0b Compare June 14, 2024 08:36
@VianneyRuhlmann VianneyRuhlmann merged commit fc6e92b into main Jun 14, 2024
29 checks passed
@VianneyRuhlmann VianneyRuhlmann deleted the vianney/actions/run-clippy-on-windows branch June 14, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-build profiling Relates to the profiling* modules.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants