Encode the file path in url authority so we don't crash on whitespaces

[paullegranddc]

What does this PR do?

Encode the file path in url authority so we don't crash on whitespaces

Motivation

The telemetry lib would fail because of a panic on URI violation, because we were trying to encode the file path in the url path, which doesn't accept some characters.

This PR encodes the path as hex, like we do for unix socket and windows pipe.

Additional Notes

Anything else we should know when reviewing?

How to test the change?

Describe here in detail how the change can be validated.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 71.73913% with 13 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@88cb232). Learn more about missing BASE report.
Report is 14 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #499   +/-   ##
=======================================
  Coverage        ?   70.39%           
=======================================
  Files           ?      204           
  Lines           ?    27843           
  Branches        ?        0           
=======================================
  Hits            ?    19600           
  Misses          ?     8243           
  Partials        ?        0           

Components	Coverage Δ
crashtracker	16.72% <0.00%> (?)
datadog-alloc	98.76% <ø> (?)
data-pipeline	51.15% <ø> (?)
data-pipeline-ffi	0.00% <ø> (?)
ddcommon	86.22% <95.65%> (?)
ddcommon-ffi	75.31% <100.00%> (?)
ddtelemetry	59.33% <84.61%> (?)
ipc	84.66% <ø> (?)
profiling	78.63% <ø> (?)
profiling-ffi	58.19% <ø> (?)
serverless	0.00% <ø> (?)
sidecar	36.19% <ø> (?)
sidecar-ffi	0.00% <ø> (?)
spawn-worker	54.98% <ø> (?)
trace-mini-agent	69.70% <ø> (?)
trace-normalization	97.79% <ø> (?)
trace-obfuscation	95.75% <ø> (?)
trace-protobuf	77.16% <ø> (?)
trace-utils	91.21% <ø> (?)

[bantonsson]

So why don't we URL encode the path with %20 for space etc?

[chrisnas]

So why don't we URL encode the path with %20 for space etc?

Would %20 work for a file path on Windows?

Since I found this issue by calling ddog_endpoint_from_url(), would it be possible to add a test to validate that it does not return a null pointer?

[paullegranddc]

So why don't we URL encode the path with %20 for space etc?

I reused the existing method to encode paths in urls. In the end it doesn't really matter because it's just an internal representation.
As to why we use the authority instead of the path of the uri to smuggle the path for unix sockets and windows, it was because the authority of hyper::Uri needs to be non empty anyway, and I was afraid the authority was used in hyper client to implement connection reuse, so a connection to a socket would be reused to connect to another path.

[bantonsson]

Thanks for the explanation.