-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEBUG-2509 Add option to skip checks when building profiling #513
Conversation
Adds -T option to build-profiling-ffi.sh script to skip post-build checks, which is frequently done during development. Also adds a usage blurb which can be printed with -h option, and prints the usage blurb if the required positional parameter of destination directory is not provided instead of failing with a non-descriptive error.
BenchmarksComparisonParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics. CandidateCandidate benchmark detailsGroup 1
Warnings
BaselineBaseline benchmark detailsGroup 1
Warnings
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #513 +/- ##
=======================================
Coverage 70.37% 70.37%
=======================================
Files 204 204
Lines 27824 27824
=======================================
Hits 19581 19581
Misses 8243 8243
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
I know @r1viollet has been working to get rid of this script, but this seems a useful + harmless UX improvement to have until we can kill it off :)
Adds -T option to build-profiling-ffi.sh script to skip post-build checks, which is frequently done during development. Also adds a usage blurb which can be printed with -h option, and prints the usage blurb if the required positional parameter of destination directory is not provided instead of failing with a non-descriptive error. Co-authored-by: Oleg Pudeyev <code@olegp.name>
What does this PR do?
Adds -T option to build-profiling-ffi.sh script to skip post-build checks, which is frequently done during development.
Also adds a usage blurb which can be printed with -h option, and prints the usage blurb if the required positional parameter of destination directory is not provided instead of failing with a non-descriptive error.
Motivation
Current diagnostics are not indicating what is wrong when the positional argument is not supplied.
Additional Notes
None
How to test the change?
Run
./build-profiling-ffi.sh -h
or./build-profiling-ffi.sh -T
.