-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEBUG-2510 Document cbindgen dependency #514
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksComparisonParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics. CandidateCandidate benchmark detailsGroup 1
Warnings
BaselineBaseline benchmark detailsGroup 1
Warnings
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #514 +/- ##
=======================================
Coverage 70.38% 70.38%
=======================================
Files 204 204
Lines 27835 27835
=======================================
Hits 19591 19591
Misses 8244 8244
|
bantonsson
approved these changes
Jun 28, 2024
p-datadog
changed the title
Document cbindgen dependency
DEBUG-2510 Document cbindgen dependency
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds
cbindgen
and its required version to the readme to the requirements section.Motivation
Building C headers requires
cbindgen
which is not mentioned in the readme.Ubuntu package of
cbindgen
is of an old version which does not work, producing cryptic errors.Additional Notes
None
How to test the change?
N/A