Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PROF-10099] Package libdatadog v10.0.0 for Ruby #517

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

ivoanjo
Copy link
Member

@ivoanjo ivoanjo commented Jul 3, 2024

What does this PR do?

This PR includes the changes documented in the "Releasing a new version to rubygems.org" part of the README: https://github.com/datadog/libdatadog/tree/main/ruby#releasing-a-new-version-to-rubygemsorg

(It's also very similar to the v9.0.0 release PR).

Motivation

Enable Ruby to use libdatadog v10.0.0.

Additional Notes

N/A

How to test the change?

I've tested this release locally using the changes in DataDog/dd-trace-rb#3753 .

As a reminder, new libdatadog releases don't get automatically picked up by dd-trace-rb, so the PR that bumps the Ruby profiler will also test this release against all supported Ruby versions.

**What does this PR do?**

This PR includes the changes documented in the "Releasing a new version to rubygems.org" part of the README:
https://github.com/datadog/libdatadog/tree/main/ruby#releasing-a-new-version-to-rubygemsorg

(It's also very similar to the v9.0.0 release PR).

**Motivation:**

Enable Ruby to use libdatadog v10.0.0.

**Additional Notes:**

N/A

**How to test the change?**

I've tested this release locally using the changes in
DataDog/dd-trace-rb#3753 .

As a reminder, new libdatadog releases don't get automatically picked
up by dd-trace-rb, so the PR that bumps the Ruby profiler will also
test this release against all supported Ruby versions.
@ivoanjo ivoanjo requested a review from a team as a code owner July 3, 2024 07:53
@pr-commenter
Copy link

pr-commenter bot commented Jul 3, 2024

Benchmarks

Comparison

Parameters

Baseline Candidate
config baseline candidate
git_branch main ivoanjo/libdatadog10-ruby
git_commit_date 1719935341 1719993079
git_commit_sha c00ab02 88b0b78
iterations 717.0 716.0
See matching parameters
Baseline Candidate
ci_job_date 1719993441 1719993441
ci_job_id 560657751 560657751
ci_pipeline_id 38225653 38225653
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

Candidate

Candidate benchmark details

Group 1

iterations config cpu_model ci_job_date ci_job_id ci_pipeline_id git_commit_sha git_commit_date git_branch
716.0 candidate Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1719993441 560657751 38225653 88b0b78 1719993079 ivoanjo/libdatadog10-ruby
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 69.817µs 69.893µs ± 0.031µs 69.898µs ± 0.018µs 69.913µs 69.937µs 69.960µs 69.988µs 0.13% -0.128 0.195 0.04% 0.003µs 1 100
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [69.887µs; 69.899µs] or [-0.009%; +0.009%] None None None

Warnings

Scenario: sql/obfuscate_sql_string, Metric: execution_time

Measurements are autocorrelated.

Autocorrelation is present for lags 1..10.

The measurements are not independent, thus confidence intervals
may be less precise.
---------------------------------------------------------------------------
Scenario: sql/obfuscate_sql_string, Metric: execution_time

Sample size is 100, which is lower than 105.

The minimal sample size in case of normal distribution to achieve significance
level of 0.05 for difference of means with effect size Cohen's d = 0.5 must be at
least 105.

The conclusions from confidence intervals may be invalid.
---------------------------------------------------------------------------

Baseline

Baseline benchmark details

Group 1

iterations config cpu_model ci_job_date ci_job_id ci_pipeline_id git_commit_sha git_commit_date git_branch
717.0 baseline Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1719993441 560657751 38225653 c00ab02 1719935341 main
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 69.611µs 69.709µs ± 0.038µs 69.712µs ± 0.024µs 69.735µs 69.764µs 69.775µs 69.798µs 0.12% -0.297 -0.323 0.05% 0.004µs 1 100
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [69.701µs; 69.716µs] or [-0.011%; +0.011%] None None None

Warnings

Scenario: sql/obfuscate_sql_string, Metric: execution_time

Sample size is 100, which is lower than 105.

The minimal sample size in case of normal distribution to achieve significance
level of 0.05 for difference of means with effect size Cohen's d = 0.5 must be at
least 105.

The conclusions from confidence intervals may be invalid.
---------------------------------------------------------------------------

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.40%. Comparing base (c00ab02) to head (88b0b78).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #517   +/-   ##
=======================================
  Coverage   70.40%   70.40%           
=======================================
  Files         204      204           
  Lines       27882    27882           
=======================================
  Hits        19630    19630           
  Misses       8252     8252           
Components Coverage Δ
crashtracker 16.70% <ø> (ø)
datadog-alloc 98.76% <ø> (ø)
data-pipeline 51.15% <ø> (ø)
data-pipeline-ffi 0.00% <ø> (ø)
ddcommon 86.49% <ø> (ø)
ddcommon-ffi 74.15% <ø> (ø)
ddtelemetry 59.37% <ø> (ø)
ipc 84.66% <ø> (ø)
profiling 78.63% <ø> (ø)
profiling-ffi 58.19% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 36.19% <ø> (ø)
sidecar-ffi 0.00% <ø> (ø)
spawn-worker 54.98% <ø> (ø)
trace-mini-agent 69.70% <ø> (ø)
trace-normalization 97.79% <ø> (ø)
trace-obfuscation 95.75% <ø> (ø)
trace-protobuf 77.16% <ø> (ø)
trace-utils 90.84% <ø> (ø)

@ivoanjo ivoanjo merged commit b82cbf3 into main Jul 3, 2024
42 checks passed
@ivoanjo ivoanjo deleted the ivoanjo/libdatadog10-ruby branch July 3, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants