Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[crashtracker] Use common Endpoint to further decouple from profiler #549

Merged
merged 2 commits into from
Jul 26, 2024

Conversation

danielsn
Copy link
Contributor

@danielsn danielsn commented Jul 25, 2024

What does this PR do?

Uses the ddcommon::Endpoint rather than the profiling-ffi::exporter::Endpoint.

Motivation

We're trying to decouple the crashtracker and the profiler, this removes one of the final remaining links.

Additional Notes

This is a breaking change for users of the API.
Eventually, the profiling-ffi endpoint type itself should probably be unified with this.

How to test the change?

Compile and run the modified example file.

PROF-10245

@danielsn danielsn requested review from a team as code owners July 25, 2024 17:37
@github-actions github-actions bot added profiling Relates to the profiling* modules. common labels Jul 25, 2024
@pr-commenter
Copy link

pr-commenter bot commented Jul 25, 2024

Benchmarks

This comment was omitted because it was over 65536 characters.Please check the Gitlab Job logs to see its output.

@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 70.45%. Comparing base (32d5eae) to head (370f8d1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #549      +/-   ##
==========================================
- Coverage   70.46%   70.45%   -0.01%     
==========================================
  Files         213      213              
  Lines       28425    28429       +4     
==========================================
  Hits        20031    20031              
- Misses       8394     8398       +4     
Components Coverage Δ
crashtracker 25.21% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 50.00% <ø> (ø)
data-pipeline-ffi 0.00% <ø> (ø)
ddcommon 86.23% <0.00%> (-0.20%) ⬇️
ddcommon-ffi 74.58% <0.00%> (-0.72%) ⬇️
ddtelemetry 58.95% <ø> (ø)
ipc 84.18% <ø> (ø)
profiling 78.09% <0.00%> (ø)
profiling-ffi 56.76% <0.00%> (ø)
serverless 0.00% <ø> (ø)
sidecar 35.42% <ø> (ø)
sidecar-ffi 0.00% <ø> (ø)
spawn-worker 54.98% <ø> (ø)
trace-mini-agent 71.14% <ø> (ø)
trace-normalization 98.24% <ø> (ø)
trace-obfuscation 95.73% <ø> (ø)
trace-protobuf 77.16% <ø> (ø)
trace-utils 91.03% <ø> (ø)

@danielsn
Copy link
Contributor Author

PROF-10245

@danielsn danielsn merged commit eb62a6d into main Jul 26, 2024
32 checks passed
@danielsn danielsn deleted the dsn/crashtracker-common-endpoint branch July 26, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common profiling Relates to the profiling* modules.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants