Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmark for SpanConcentrator #603

Merged

Conversation

VianneyRuhlmann
Copy link
Contributor

What does this PR do?

Add benchmark to concentrator to allow future otpimizations

Motivation

The concentrator is lacking some optimizations, this will make it easier to evaluate improvement.

Additional Notes

Anything else we should know when reviewing?

How to test the change?

Describe here in detail how the change can be validated.

@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.88%. Comparing base (081589b) to head (56c8802).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #603   +/-   ##
=======================================
  Coverage   72.88%   72.88%           
=======================================
  Files         245      245           
  Lines       34951    34951           
=======================================
  Hits        25473    25473           
  Misses       9478     9478           
Components Coverage Δ
crashtracker 20.44% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 90.12% <ø> (ø)
data-pipeline-ffi 0.00% <ø> (ø)
ddcommon 82.82% <ø> (ø)
ddcommon-ffi 68.11% <ø> (ø)
ddtelemetry 59.02% <ø> (ø)
ipc 83.61% <ø> (ø)
profiling 84.26% <ø> (ø)
profiling-ffi 77.42% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 40.13% <ø> (ø)
sidecar-ffi 0.00% <ø> (ø)
spawn-worker 50.36% <ø> (ø)
tinybytes 91.66% <ø> (ø)
trace-mini-agent 70.88% <ø> (ø)
trace-normalization 98.25% <ø> (ø)
trace-obfuscation 95.73% <ø> (ø)
trace-protobuf 77.67% <ø> (ø)
trace-utils 93.00% <ø> (ø)

@pr-commenter
Copy link

pr-commenter bot commented Aug 29, 2024

Benchmarks

Comparison

Benchmark execution time: 2024-09-04 11:38:49

Comparing candidate commit 56c8802 in PR branch vianney/data-pipeline/add-benchmark-for-concentrator with baseline commit 081589b in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 56c8802 1725449397 vianney/data-pipeline/add-benchmark-for-concentrator
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 1.211µs 1.212µs ± 0.000µs 1.212µs ± 0.000µs 1.212µs 1.213µs 1.213µs 1.214µs 0.12% 1.118 2.356 0.03% 0.000µs 1 200
credit_card/is_card_number/ throughput 824061270.439op/s 825052264.762op/s ± 222168.780op/s 825067653.771op/s ± 153976.359op/s 825234281.781op/s 825326144.775op/s 825417258.456op/s 825425878.827op/s 0.04% -1.115 2.346 0.03% 15709.705op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 111.725µs 114.619µs ± 1.438µs 114.578µs ± 0.792µs 115.385µs 116.854µs 119.106µs 121.026µs 5.63% 0.753 2.058 1.25% 0.102µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 8262657.100op/s 8725939.718op/s ± 108567.042op/s 8727678.533op/s ± 60301.020op/s 8785886.424op/s 8904192.453op/s 8940524.825op/s 8950513.627op/s 2.55% -0.627 1.678 1.24% 7676.849op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 106.638µs 108.844µs ± 1.015µs 108.778µs ± 0.704µs 109.497µs 110.596µs 111.268µs 111.461µs 2.47% 0.304 -0.428 0.93% 0.072µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 8971713.844op/s 9188243.247op/s ± 85466.447op/s 9193021.589op/s ± 59774.422op/s 9252227.685op/s 9312389.836op/s 9355246.462op/s 9377553.663op/s 2.01% -0.263 -0.461 0.93% 6043.390op/s 1 200
credit_card/is_card_number/37828224631 execution_time 1.212µs 1.213µs ± 0.003µs 1.212µs ± 0.000µs 1.214µs 1.215µs 1.216µs 1.250µs 3.10% 10.493 130.572 0.24% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 800169397.357op/s 824476803.797op/s ± 1916473.909op/s 824987321.754op/s ± 264791.867op/s 825224213.212op/s 825318102.498op/s 825348766.991op/s 825401526.582op/s 0.05% -10.332 127.780 0.23% 135515.170op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 102.877µs 105.672µs ± 1.019µs 105.592µs ± 0.684µs 106.414µs 107.312µs 108.106µs 108.500µs 2.75% 0.046 0.044 0.96% 0.072µs 1 200
credit_card/is_card_number/378282246310005 throughput 9216620.263op/s 9464144.145op/s ± 91224.047op/s 9470400.265op/s ± 61499.720op/s 9523023.869op/s 9604988.780op/s 9696188.702op/s 9720319.796op/s 2.64% 0.013 0.062 0.96% 6450.514op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 100.743µs 101.480µs ± 0.349µs 101.434µs ± 0.220µs 101.689µs 102.101µs 102.370µs 103.105µs 1.65% 0.776 1.735 0.34% 0.025µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 9698887.743op/s 9854310.171op/s ± 33838.307op/s 9858601.275op/s ± 21442.031op/s 9875984.569op/s 9901609.706op/s 9917534.720op/s 9926282.812op/s 0.69% -0.744 1.619 0.34% 2392.730op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 20.393µs 21.703µs ± 0.546µs 21.719µs ± 0.388µs 22.144µs 22.529µs 22.721µs 22.762µs 4.80% -0.344 -0.519 2.51% 0.039µs 1 200
credit_card/is_card_number/x371413321323331 throughput 43932757.039op/s 46105206.792op/s ± 1170501.032op/s 46041732.598op/s ± 814280.504op/s 46813218.238op/s 48192779.167op/s 48985242.067op/s 49036779.828op/s 6.51% 0.447 -0.414 2.53% 82766.922op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 1.212µs 1.213µs ± 0.001µs 1.213µs ± 0.000µs 1.213µs 1.214µs 1.214µs 1.215µs 0.21% 0.280 0.801 0.05% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 822816820.131op/s 824623700.578op/s ± 403479.183op/s 824576785.969op/s ± 305915.711op/s 824928602.478op/s 825243822.414op/s 825335953.005op/s 825421047.276op/s 0.10% -0.276 0.787 0.05% 28530.287op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 90.384µs 91.600µs ± 0.529µs 91.620µs ± 0.306µs 91.890µs 92.491µs 92.917µs 93.161µs 1.68% 0.187 0.054 0.58% 0.037µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 10734102.331op/s 10917385.929op/s ± 63025.066op/s 10914626.341op/s ± 36388.089op/s 10959435.584op/s 11017543.014op/s 11057712.202op/s 11063863.942op/s 1.37% -0.152 0.023 0.58% 4456.545op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 83.032µs 84.913µs ± 0.970µs 85.245µs ± 0.296µs 85.485µs 85.903µs 86.807µs 86.931µs 1.98% -0.849 -0.431 1.14% 0.069µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 11503433.434op/s 11778365.107op/s ± 135928.798op/s 11730911.983op/s ± 40761.673op/s 11798302.300op/s 12020582.681op/s 12022695.403op/s 12043569.142op/s 2.67% 0.877 -0.435 1.15% 9611.617op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 1.211µs 1.212µs ± 0.000µs 1.212µs ± 0.000µs 1.212µs 1.213µs 1.213µs 1.214µs 0.13% 1.125 2.211 0.03% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 823971414.346op/s 825034829.403op/s ± 235661.817op/s 825050650.388op/s ± 151126.260op/s 825207735.142op/s 825331658.021op/s 825349862.977op/s 825426085.686op/s 0.05% -1.123 2.200 0.03% 16663.807op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 80.689µs 81.796µs ± 0.333µs 81.784µs ± 0.144µs 81.912µs 82.414µs 82.692µs 83.341µs 1.90% 0.683 3.239 0.41% 0.024µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 11998938.240op/s 12225765.598op/s ± 49583.912op/s 12227393.143op/s ± 21628.270op/s 12250071.165op/s 12295275.862op/s 12353193.552op/s 12393236.799op/s 1.36% -0.625 3.138 0.40% 3506.112op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 100.593µs 101.499µs ± 0.343µs 101.488µs ± 0.230µs 101.724µs 102.073µs 102.312µs 102.593µs 1.09% 0.316 0.058 0.34% 0.024µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 9747216.284op/s 9852444.818op/s ± 33239.045op/s 9853390.043op/s ± 22369.633op/s 9874865.014op/s 9902859.452op/s 9921356.275op/s 9941079.523op/s 0.89% -0.296 0.040 0.34% 2350.355op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 20.363µs 21.871µs ± 0.540µs 21.903µs ± 0.400µs 22.269µs 22.698µs 22.896µs 23.208µs 5.96% -0.176 -0.438 2.46% 0.038µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 43089338.468op/s 45751256.835op/s ± 1136552.939op/s 45655857.730op/s ± 838978.625op/s 46525974.185op/s 47737800.314op/s 48351620.691op/s 49108015.487op/s 7.56% 0.291 -0.341 2.48% 80366.429op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [1.212µs; 1.212µs] or [-0.004%; +0.004%] None None None
credit_card/is_card_number/ throughput [825021474.306op/s; 825083055.218op/s] or [-0.004%; +0.004%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [114.419µs; 114.818µs] or [-0.174%; +0.174%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [8710893.370op/s; 8740986.066op/s] or [-0.172%; +0.172%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [108.703µs; 108.985µs] or [-0.129%; +0.129%] None None None
credit_card/is_card_number/ 378282246310005 throughput [9176398.419op/s; 9200088.075op/s] or [-0.129%; +0.129%] None None None
credit_card/is_card_number/37828224631 execution_time [1.212µs; 1.213µs] or [-0.033%; +0.033%] None None None
credit_card/is_card_number/37828224631 throughput [824211198.945op/s; 824742408.649op/s] or [-0.032%; +0.032%] None None None
credit_card/is_card_number/378282246310005 execution_time [105.531µs; 105.813µs] or [-0.134%; +0.134%] None None None
credit_card/is_card_number/378282246310005 throughput [9451501.370op/s; 9476786.921op/s] or [-0.134%; +0.134%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [101.431µs; 101.528µs] or [-0.048%; +0.048%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [9849620.507op/s; 9858999.835op/s] or [-0.048%; +0.048%] None None None
credit_card/is_card_number/x371413321323331 execution_time [21.628µs; 21.779µs] or [-0.348%; +0.348%] None None None
credit_card/is_card_number/x371413321323331 throughput [45942986.606op/s; 46267426.978op/s] or [-0.352%; +0.352%] None None None
credit_card/is_card_number_no_luhn/ execution_time [1.213µs; 1.213µs] or [-0.007%; +0.007%] None None None
credit_card/is_card_number_no_luhn/ throughput [824567782.244op/s; 824679618.912op/s] or [-0.007%; +0.007%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [91.527µs; 91.673µs] or [-0.080%; +0.080%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [10908651.261op/s; 10926120.597op/s] or [-0.080%; +0.080%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [84.778µs; 85.047µs] or [-0.158%; +0.158%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [11759526.683op/s; 11797203.531op/s] or [-0.160%; +0.160%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [1.212µs; 1.212µs] or [-0.004%; +0.004%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [825002168.942op/s; 825067489.864op/s] or [-0.004%; +0.004%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [81.750µs; 81.842µs] or [-0.056%; +0.056%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [12218893.745op/s; 12232637.451op/s] or [-0.056%; +0.056%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [101.451µs; 101.546µs] or [-0.047%; +0.047%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [9847838.206op/s; 9857051.430op/s] or [-0.047%; +0.047%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [21.796µs; 21.946µs] or [-0.342%; +0.342%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [45593741.528op/s; 45908772.141op/s] or [-0.344%; +0.344%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 56c8802 1725449397 vianney/data-pipeline/add-benchmark-for-concentrator
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 301.271µs 307.701µs ± 3.728µs 309.910µs ± 1.580µs 310.938µs 311.734µs 312.049µs 312.223µs 0.75% -0.340 -1.739 1.21% 0.264µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 3202841.656op/s 3250387.886op/s ± 39543.877op/s 3226739.423op/s ± 16364.441op/s 3294387.773op/s 3304483.223op/s 3310943.580op/s 3319265.385op/s 2.87% 0.346 -1.737 1.21% 2796.174op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 28.454µs 28.644µs ± 0.200µs 28.625µs ± 0.048µs 28.677µs 28.750µs 28.831µs 31.278µs 9.27% 11.490 148.756 0.70% 0.014µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 31971184.961op/s 34912906.112op/s ± 226092.059op/s 34934971.772op/s ± 58852.523op/s 34987247.928op/s 35055325.220op/s 35109794.193op/s 35144983.292op/s 0.60% -11.093 141.814 0.65% 15987.123op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 16.506µs 16.539µs ± 0.020µs 16.537µs ± 0.017µs 16.555µs 16.573µs 16.585µs 16.605µs 0.41% 0.412 -0.632 0.12% 0.001µs 1 200
normalization/normalize_name/normalize_name/good throughput 60222636.859op/s 60463726.092op/s ± 74853.547op/s 60469609.069op/s ± 61672.932op/s 60529276.341op/s 60560825.087op/s 60580083.651op/s 60582796.053op/s 0.19% -0.408 -0.642 0.12% 5292.945op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [307.184µs; 308.217µs] or [-0.168%; +0.168%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [3244907.485op/s; 3255868.287op/s] or [-0.169%; +0.169%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [28.616µs; 28.672µs] or [-0.097%; +0.097%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [34881571.927op/s; 34944240.297op/s] or [-0.090%; +0.090%] None None None
normalization/normalize_name/normalize_name/good execution_time [16.536µs; 16.542µs] or [-0.017%; +0.017%] None None None
normalization/normalize_name/normalize_name/good throughput [60453352.111op/s; 60474100.074op/s] or [-0.017%; +0.017%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 56c8802 1725449397 vianney/data-pipeline/add-benchmark-for-concentrator
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 136.336µs 136.781µs ± 0.262µs 136.747µs ± 0.152µs 136.905µs 137.202µs 137.523µs 137.951µs 0.88% 1.176 2.401 0.19% 0.019µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [136.745µs; 136.818µs] or [-0.027%; +0.027%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 56c8802 1725449397 vianney/data-pipeline/add-benchmark-for-concentrator
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 1.185µs 1.388µs ± 0.060µs 1.402µs ± 0.038µs 1.432µs 1.466µs 1.480µs 1.481µs 5.60% -0.880 0.979 4.28% 0.004µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [1.380µs; 1.396µs] or [-0.595%; +0.595%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 56c8802 1725449397 vianney/data-pipeline/add-benchmark-for-concentrator
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.636µs 2.695µs ± 0.018µs 2.693µs ± 0.008µs 2.707µs 2.720µs 2.730µs 2.731µs 1.40% -0.900 1.745 0.67% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.692µs; 2.697µs] or [-0.092%; +0.092%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 56c8802 1725449397 vianney/data-pipeline/add-benchmark-for-concentrator
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 16.765µs 22.128µs ± 12.042µs 17.159µs ± 0.285µs 17.996µs 50.052µs 51.507µs 115.101µs 570.79% 3.417 17.437 54.29% 0.852µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [20.459µs; 23.796µs] or [-7.542%; +7.542%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 56c8802 1725449397 vianney/data-pipeline/add-benchmark-for-concentrator
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 38.801µs 39.340µs ± 0.890µs 38.930µs ± 0.062µs 39.031µs 41.236µs 41.251µs 42.254µs 8.54% 1.714 1.073 2.26% 0.063µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [39.217µs; 39.464µs] or [-0.314%; +0.314%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 56c8802 1725449397 vianney/data-pipeline/add-benchmark-for-concentrator
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 75.163µs 75.368µs ± 0.178µs 75.339µs ± 0.043µs 75.390µs 75.505µs 75.844µs 77.539µs 2.92% 9.419 109.651 0.24% 0.013µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [75.344µs; 75.393µs] or [-0.033%; +0.033%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 56c8802 1725449397 vianney/data-pipeline/add-benchmark-for-concentrator
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 618.664µs 619.140µs ± 0.228µs 619.124µs ± 0.159µs 619.295µs 619.487µs 619.769µs 619.931µs 0.13% 0.473 0.501 0.04% 0.016µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1613082.573op/s 1615144.555op/s ± 595.612op/s 1615184.109op/s ± 415.518op/s 1615593.275op/s 1616080.910op/s 1616353.557op/s 1616385.581op/s 0.07% -0.471 0.496 0.04% 42.116op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 466.000µs 467.655µs ± 1.804µs 467.457µs ± 0.745µs 468.226µs 469.204µs 469.641µs 489.105µs 4.63% 8.469 98.184 0.38% 0.128µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2044552.521op/s 2138356.995op/s ± 7991.593op/s 2139233.475op/s ± 3416.130op/s 2142566.608op/s 2144975.181op/s 2145712.962op/s 2145924.686op/s 0.31% -8.145 93.058 0.37% 565.091op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 190.592µs 190.926µs ± 0.602µs 190.884µs ± 0.079µs 190.971µs 191.074µs 191.252µs 199.222µs 4.37% 13.188 179.343 0.31% 0.043µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5019516.911op/s 5237670.880op/s ± 15854.504op/s 5238783.412op/s ± 2155.659op/s 5240855.790op/s 5243785.399op/s 5246097.106op/s 5246819.116op/s 0.15% -13.117 178.043 0.30% 1121.083op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 46.924µs 47.281µs ± 0.130µs 47.294µs ± 0.092µs 47.379µs 47.486µs 47.544µs 47.647µs 0.75% -0.155 -0.072 0.27% 0.009µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 20987493.266op/s 21150351.955op/s ± 58169.262op/s 21144172.009op/s ± 41014.307op/s 21188265.359op/s 21250303.659op/s 21288486.811op/s 21310945.087op/s 0.79% 0.170 -0.068 0.27% 4113.188op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 51.298µs 51.508µs ± 0.099µs 51.501µs ± 0.062µs 51.560µs 51.676µs 51.751µs 51.997µs 0.96% 0.827 2.216 0.19% 0.007µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 19231773.087op/s 19414388.782op/s ± 37291.002op/s 19416964.047op/s ± 23329.353op/s 19441618.218op/s 19469687.886op/s 19485683.910op/s 19493842.383op/s 0.40% -0.807 2.129 0.19% 2636.872op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [619.108µs; 619.171µs] or [-0.005%; +0.005%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1615062.009op/s; 1615227.101op/s] or [-0.005%; +0.005%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [467.406µs; 467.905µs] or [-0.053%; +0.053%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2137249.437op/s; 2139464.553op/s] or [-0.052%; +0.052%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [190.843µs; 191.010µs] or [-0.044%; +0.044%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5235473.598op/s; 5239868.162op/s] or [-0.042%; +0.042%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [47.263µs; 47.299µs] or [-0.038%; +0.038%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [21142290.255op/s; 21158413.655op/s] or [-0.038%; +0.038%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [51.495µs; 51.522µs] or [-0.027%; +0.027%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [19409220.608op/s; 19419556.957op/s] or [-0.027%; +0.027%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 56c8802 1725449397 vianney/data-pipeline/add-benchmark-for-concentrator
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 9.229ms 9.263ms ± 0.015ms 9.262ms ± 0.009ms 9.272ms 9.284ms 9.305ms 9.310ms 0.52% 0.380 0.670 0.16% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [9.261ms; 9.265ms] or [-0.022%; +0.022%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 56c8802 1725449397 vianney/data-pipeline/add-benchmark-for-concentrator
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 294.358ns 308.190ns ± 15.972ns 301.580ns ± 3.560ns 310.126ns 344.482ns 351.324ns 351.619ns 16.59% 1.499 0.948 5.17% 1.129ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [305.976ns; 310.403ns] or [-0.718%; +0.718%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 56c8802 1725449397 vianney/data-pipeline/add-benchmark-for-concentrator
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.428µs 2.907µs ± 1.411µs 2.743µs ± 0.018µs 2.759µs 2.983µs 12.583µs 16.300µs 494.26% 8.031 64.987 48.44% 0.100µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [2.711µs; 3.102µs] or [-6.730%; +6.730%] None None None

Baseline

Omitted due to size.

@VianneyRuhlmann VianneyRuhlmann marked this pull request as ready for review August 29, 2024 09:46
@VianneyRuhlmann VianneyRuhlmann requested review from a team as code owners August 29, 2024 09:46
Copy link
Contributor

@bantonsson bantonsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Only one comment about benchmark name.

data-pipeline/benches/span_concentrator.rs Outdated Show resolved Hide resolved
@VianneyRuhlmann VianneyRuhlmann force-pushed the vianney/data-pipeline/add-benchmark-for-concentrator branch from a2e8725 to e04263d Compare September 4, 2024 10:36
@VianneyRuhlmann VianneyRuhlmann merged commit c035537 into main Sep 4, 2024
40 checks passed
@VianneyRuhlmann VianneyRuhlmann deleted the vianney/data-pipeline/add-benchmark-for-concentrator branch September 4, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants