Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APMSP-1391] Wait for spawned children #651

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[APMSP-1391] Wait for spawned children #651

wants to merge 1 commit into from
+8 −4

Conversation

hoolioh
Copy link
Contributor

@hoolioh hoolioh commented Sep 26, 2024

What does this PR do?

Actively waiting for spawned children in the builder in order to avoid concurrency problems.

Motivation

Letting child process on their own could lead to issues if the parent process finish before them or another subsequent command is added that operates on the same resources.

@pr-commenter
Copy link

pr-commenter bot commented Sep 26, 2024 •
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2024-09-27 13:23:14

Comparing candidate commit 60480db in PR branch julio/wait-for-child-processes with baseline commit 1d90886 in branch main.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 50 metrics, 2 unstable metrics.

scenario:benching deserializing traces from msgpack to their internal representation

  • 🟥 execution_time [+27.505ns; +35.381ns] or [+2.291%; +2.947%]

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 60480db 1727442793 julio/wait-for-child-processes
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 318.150µs 318.483µs ± 0.160µs 318.469µs ± 0.089µs 318.575µs 318.757µs 318.992µs 319.001µs 0.17% 0.597 0.444 0.05% 0.011µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 3134790.947op/s 3139885.840op/s ± 1574.962op/s 3140027.409op/s ± 882.318op/s 3140799.505op/s 3142192.723op/s 3142826.987op/s 3143175.260op/s 0.10% -0.594 0.438 0.05% 111.367op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 29.384µs 29.513µs ± 0.054µs 29.509µs ± 0.031µs 29.541µs 29.602µs 29.635µs 29.849µs 1.15% 1.323 6.508 0.18% 0.004µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 33502243.187op/s 33883418.942op/s ± 61746.504op/s 33888317.595op/s ± 36068.350op/s 33922863.855op/s 33969430.711op/s 34006521.168op/s 34032025.127op/s 0.42% -1.286 6.265 0.18% 4366.137op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 17.284µs 17.410µs ± 0.097µs 17.411µs ± 0.087µs 17.494µs 17.567µs 17.599µs 17.729µs 1.83% 0.288 -0.777 0.56% 0.007µs 1 200
normalization/normalize_name/normalize_name/good throughput 56404923.716op/s 57438676.487op/s ± 320348.240op/s 57434799.844op/s ± 287678.396op/s 57724307.992op/s 57849800.065op/s 57852211.719op/s 57855404.016op/s 0.73% -0.269 -0.813 0.56% 22652.041op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [318.461µs; 318.505µs] or [-0.007%; +0.007%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [3139667.565op/s; 3140104.114op/s] or [-0.007%; +0.007%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [29.506µs; 29.521µs] or [-0.025%; +0.025%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [33874861.470op/s; 33891976.413op/s] or [-0.025%; +0.025%] None None None
normalization/normalize_name/normalize_name/good execution_time [17.397µs; 17.424µs] or [-0.077%; +0.077%] None None None
normalization/normalize_name/normalize_name/good throughput [57394279.302op/s; 57483073.672op/s] or [-0.077%; +0.077%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 60480db 1727442793 julio/wait-for-child-processes
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 501.623µs 502.665µs ± 0.236µs 502.627µs ± 0.138µs 502.810µs 503.101µs 503.221µs 503.332µs 0.14% -0.188 2.058 0.05% 0.017µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1986761.765op/s 1989395.523op/s ± 934.252op/s 1989545.271op/s ± 545.695op/s 1989923.250op/s 1990637.633op/s 1991522.920op/s 1993527.901op/s 0.20% 0.193 2.073 0.05% 66.062op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 464.879µs 465.398µs ± 0.296µs 465.371µs ± 0.188µs 465.555µs 465.827µs 466.178µs 467.155µs 0.38% 1.792 7.536 0.06% 0.021µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2140615.452op/s 2148699.624op/s ± 1367.056op/s 2148822.589op/s ± 866.258op/s 2149701.173op/s 2150338.944op/s 2150828.562op/s 2151095.678op/s 0.11% -1.780 7.456 0.06% 96.665op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 178.285µs 179.529µs ± 0.572µs 179.412µs ± 0.276µs 179.729µs 180.932µs 181.400µs 181.566µs 1.20% 1.295 2.298 0.32% 0.040µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5507630.217op/s 5570183.109op/s ± 17662.158op/s 5573772.657op/s ± 8585.236op/s 5581339.006op/s 5592035.672op/s 5599768.287op/s 5608983.019op/s 0.63% -1.271 2.230 0.32% 1248.903op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 44.564µs 44.930µs ± 0.101µs 44.935µs ± 0.073µs 44.996µs 45.110µs 45.159µs 45.177µs 0.54% -0.018 0.216 0.22% 0.007µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 22134970.132op/s 22256772.054op/s ± 49899.267op/s 22254222.977op/s ± 36039.937op/s 22295365.990op/s 22325235.999op/s 22372133.646op/s 22439745.776op/s 0.83% 0.033 0.233 0.22% 3528.411op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 50.349µs 50.908µs ± 0.307µs 50.842µs ± 0.236µs 51.193µs 51.376µs 51.624µs 51.816µs 1.92% 0.432 -0.736 0.60% 0.022µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 19299180.897op/s 19643949.104op/s ± 118023.255op/s 19668923.571op/s ± 91355.920op/s 19743356.123op/s 19800413.930op/s 19833641.601op/s 19861427.985op/s 0.98% -0.412 -0.767 0.60% 8345.504op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [502.633µs; 502.698µs] or [-0.007%; +0.007%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1989266.044op/s; 1989525.001op/s] or [-0.007%; +0.007%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [465.357µs; 465.439µs] or [-0.009%; +0.009%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2148510.164op/s; 2148889.085op/s] or [-0.009%; +0.009%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [179.450µs; 179.608µs] or [-0.044%; +0.044%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5567735.304op/s; 5572630.915op/s] or [-0.044%; +0.044%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [44.916µs; 44.944µs] or [-0.031%; +0.031%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [22249856.495op/s; 22263687.612op/s] or [-0.031%; +0.031%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [50.866µs; 50.951µs] or [-0.083%; +0.083%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [19627592.216op/s; 19660305.992op/s] or [-0.083%; +0.083%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 60480db 1727442793 julio/wait-for-child-processes
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 2.015µs 2.016µs ± 0.002µs 2.016µs ± 0.001µs 2.017µs 2.018µs 2.020µs 2.048µs 1.59% 10.673 130.259 0.12% 0.000µs 1 200
credit_card/is_card_number/ throughput 488245160.680op/s 495925407.472op/s ± 605549.025op/s 496002907.441op/s ± 140713.461op/s 496140819.988op/s 496205853.119op/s 496234299.365op/s 496253937.972op/s 0.05% -10.605 129.007 0.12% 42818.782op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 111.630µs 112.588µs ± 0.710µs 112.432µs ± 0.411µs 112.895µs 113.803µs 114.861µs 116.331µs 3.47% 1.686 4.895 0.63% 0.050µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 8596142.689op/s 8882302.648op/s ± 55423.400op/s 8894229.424op/s ± 32500.166op/s 8919725.802op/s 8943325.675op/s 8952941.351op/s 8958130.203op/s 0.72% -1.612 4.460 0.62% 3919.026op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 103.527µs 104.499µs ± 0.512µs 104.419µs ± 0.298µs 104.775µs 105.570µs 106.057µs 106.354µs 1.85% 0.949 1.103 0.49% 0.036µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 9402599.015op/s 9569679.775op/s ± 46686.515op/s 9576782.051op/s ± 27420.268op/s 9602859.742op/s 9631530.909op/s 9653485.188op/s 9659312.040op/s 0.86% -0.917 1.022 0.49% 3301.235op/s 1 200
credit_card/is_card_number/37828224631 execution_time 2.015µs 2.016µs ± 0.002µs 2.016µs ± 0.001µs 2.017µs 2.018µs 2.018µs 2.038µs 1.07% 10.378 129.316 0.08% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 490758308.657op/s 495945047.554op/s ± 408525.641op/s 496001240.011op/s ± 123206.999op/s 496115532.906op/s 496198347.847op/s 496245174.894op/s 496378190.543op/s 0.08% -10.319 128.313 0.08% 28887.125op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 99.955µs 101.036µs ± 0.546µs 100.990µs ± 0.398µs 101.388µs 102.000µs 102.284µs 102.697µs 1.69% 0.496 -0.270 0.54% 0.039µs 1 200
credit_card/is_card_number/378282246310005 throughput 9737373.209op/s 9897707.718op/s ± 53322.879op/s 9901968.612op/s ± 39139.376op/s 9940912.583op/s 9970494.254op/s 9994262.569op/s 10004472.707op/s 1.04% -0.473 -0.303 0.54% 3770.497op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 100.520µs 101.053µs ± 0.571µs 100.943µs ± 0.267µs 101.235µs 101.917µs 103.029µs 104.874µs 3.89% 3.322 16.894 0.56% 0.040µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 9535293.650op/s 9896108.853op/s ± 54915.201op/s 9906608.954op/s ± 26259.261op/s 9932407.484op/s 9944145.430op/s 9948117.028op/s 9948261.084op/s 0.42% -3.192 15.757 0.55% 3883.091op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 20.835µs 20.859µs ± 0.031µs 20.851µs ± 0.009µs 20.859µs 20.908µs 21.002µs 21.046µs 0.94% 3.268 13.232 0.15% 0.002µs 1 200
credit_card/is_card_number/x371413321323331 throughput 47514760.262op/s 47940894.834op/s ± 69954.141op/s 47960451.811op/s ± 20255.146op/s 47980840.051op/s 47990081.410op/s 47993636.956op/s 47997216.161op/s 0.08% -3.248 13.071 0.15% 4946.505op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 2.015µs 2.016µs ± 0.001µs 2.016µs ± 0.001µs 2.017µs 2.018µs 2.018µs 2.021µs 0.27% 1.548 6.614 0.04% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 494689863.366op/s 495980080.591op/s ± 204813.656op/s 496009920.199op/s ± 137038.531op/s 496139328.327op/s 496223739.848op/s 496281971.602op/s 496364480.438op/s 0.07% -1.540 6.555 0.04% 14482.512op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 87.434µs 89.742µs ± 0.849µs 89.556µs ± 0.436µs 90.247µs 91.154µs 92.240µs 93.000µs 3.85% 0.711 1.374 0.94% 0.060µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 10752732.562op/s 11143999.685op/s ± 104754.998op/s 11166221.091op/s ± 54097.416op/s 11206176.036op/s 11308873.411op/s 11359156.710op/s 11437144.619op/s 2.43% -0.631 1.223 0.94% 7407.297op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 80.972µs 81.430µs ± 0.265µs 81.350µs ± 0.038µs 81.403µs 82.116µs 82.428µs 82.774µs 1.75% 2.368 6.484 0.32% 0.019µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 12081069.279op/s 12280658.296op/s ± 39675.172op/s 12292540.886op/s ± 5766.252op/s 12298164.499op/s 12319308.360op/s 12345694.269op/s 12349941.930op/s 0.47% -2.340 6.338 0.32% 2805.458op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 2.015µs 2.017µs ± 0.003µs 2.016µs ± 0.001µs 2.017µs 2.018µs 2.019µs 2.052µs 1.78% 12.129 159.808 0.13% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 487276005.311op/s 495882992.272op/s ± 643415.290op/s 495951818.282op/s ± 145689.686op/s 496096924.939op/s 496155738.329op/s 496179972.911op/s 496214712.106op/s 0.05% -12.071 158.755 0.13% 45496.331op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 77.124µs 77.820µs ± 0.207µs 77.763µs ± 0.054µs 77.864µs 78.216µs 78.575µs 78.935µs 1.51% 1.830 7.265 0.27% 0.015µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 12668701.188op/s 12850178.528op/s ± 34050.453op/s 12859574.001op/s ± 9010.567op/s 12866413.195op/s 12881277.283op/s 12916372.356op/s 12966080.332op/s 0.83% -1.783 7.081 0.26% 2407.731op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 100.506µs 100.987µs ± 0.429µs 100.884µs ± 0.223µs 101.187µs 101.668µs 102.700µs 103.765µs 2.86% 2.514 10.886 0.42% 0.030µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 9637154.325op/s 9902459.340op/s ± 41607.391op/s 9912359.228op/s ± 21932.797op/s 9931691.282op/s 9946363.831op/s 9948117.802op/s 9949687.746op/s 0.38% -2.432 10.239 0.42% 2942.087op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 20.847µs 20.956µs ± 0.085µs 20.940µs ± 0.055µs 21.007µs 21.094µs 21.167µs 21.437µs 2.37% 1.350 3.846 0.41% 0.006µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 46648053.179op/s 47719309.071op/s ± 193620.403op/s 47754984.037op/s ± 126268.047op/s 47860848.964op/s 47948618.585op/s 47963437.335op/s 47967503.024op/s 0.45% -1.302 3.529 0.40% 13691.030op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [2.016µs; 2.017µs] or [-0.017%; +0.017%] None None None
credit_card/is_card_number/ throughput [495841484.201op/s; 496009330.743op/s] or [-0.017%; +0.017%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [112.489µs; 112.686µs] or [-0.087%; +0.087%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [8874621.498op/s; 8889983.798op/s] or [-0.086%; +0.086%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [104.428µs; 104.570µs] or [-0.068%; +0.068%] None None None
credit_card/is_card_number/ 378282246310005 throughput [9563209.473op/s; 9576150.077op/s] or [-0.068%; +0.068%] None None None
credit_card/is_card_number/37828224631 execution_time [2.016µs; 2.017µs] or [-0.012%; +0.012%] None None None
credit_card/is_card_number/37828224631 throughput [495888429.829op/s; 496001665.278op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/378282246310005 execution_time [100.961µs; 101.112µs] or [-0.075%; +0.075%] None None None
credit_card/is_card_number/378282246310005 throughput [9890317.680op/s; 9905097.756op/s] or [-0.075%; +0.075%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [100.974µs; 101.132µs] or [-0.078%; +0.078%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [9888498.134op/s; 9903719.572op/s] or [-0.077%; +0.077%] None None None
credit_card/is_card_number/x371413321323331 execution_time [20.855µs; 20.863µs] or [-0.020%; +0.020%] None None None
credit_card/is_card_number/x371413321323331 throughput [47931199.863op/s; 47950589.805op/s] or [-0.020%; +0.020%] None None None
credit_card/is_card_number_no_luhn/ execution_time [2.016µs; 2.016µs] or [-0.006%; +0.006%] None None None
credit_card/is_card_number_no_luhn/ throughput [495951695.388op/s; 496008465.794op/s] or [-0.006%; +0.006%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [89.625µs; 89.860µs] or [-0.131%; +0.131%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [11129481.650op/s; 11158517.720op/s] or [-0.130%; +0.130%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [81.393µs; 81.466µs] or [-0.045%; +0.045%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [12275159.699op/s; 12286156.893op/s] or [-0.045%; +0.045%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [2.016µs; 2.017µs] or [-0.018%; +0.018%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [495793821.101op/s; 495972163.443op/s] or [-0.018%; +0.018%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [77.792µs; 77.849µs] or [-0.037%; +0.037%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [12845459.462op/s; 12854897.593op/s] or [-0.037%; +0.037%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [100.927µs; 101.046µs] or [-0.059%; +0.059%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [9896692.956op/s; 9908225.725op/s] or [-0.058%; +0.058%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [20.944µs; 20.968µs] or [-0.057%; +0.057%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [47692475.146op/s; 47746142.997op/s] or [-0.056%; +0.056%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 60480db 1727442793 julio/wait-for-child-processes
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 305.581ns 318.040ns ± 14.675ns 309.382ns ± 2.961ns 324.975ns 350.509ns 355.516ns 356.393ns 15.20% 1.165 -0.005 4.60% 1.038ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [316.006ns; 320.074ns] or [-0.639%; +0.639%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 60480db 1727442793 julio/wait-for-child-processes
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.359µs 3.188µs ± 1.572µs 3.034µs ± 0.024µs 3.055µs 3.121µs 13.831µs 18.244µs 501.31% 8.029 65.432 49.19% 0.111µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [2.970µs; 3.406µs] or [-6.834%; +6.834%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 60480db 1727442793 julio/wait-for-child-processes
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 37.474µs 38.117µs ± 1.129µs 37.600µs ± 0.096µs 37.737µs 40.522µs 40.546µs 41.014µs 9.08% 1.649 0.768 2.95% 0.080µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [37.961µs; 38.273µs] or [-0.410%; +0.410%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 60480db 1727442793 julio/wait-for-child-processes
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 141.549µs 142.299µs ± 0.547µs 142.257µs ± 0.173µs 142.396µs 142.926µs 143.547µs 147.520µs 3.70% 5.712 47.199 0.38% 0.039µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [142.224µs; 142.375µs] or [-0.053%; +0.053%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 60480db 1727442793 julio/wait-for-child-processes
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.807µs 23.141µs ± 9.908µs 18.987µs ± 0.329µs 19.650µs 37.352µs 39.558µs 98.758µs 420.13% 3.967 23.220 42.71% 0.701µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [21.768µs; 24.514µs] or [-5.934%; +5.934%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 60480db 1727442793 julio/wait-for-child-processes
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 1.176µs 1.232µs ± 0.020µs 1.235µs ± 0.013µs 1.248µs 1.252µs 1.253µs 1.258µs 1.85% -1.228 0.836 1.65% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [1.229µs; 1.235µs] or [-0.229%; +0.229%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 60480db 1727442793 julio/wait-for-child-processes
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.700µs 2.725µs ± 0.012µs 2.725µs ± 0.007µs 2.733µs 2.748µs 2.751µs 2.754µs 1.04% 0.070 -0.236 0.43% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.723µs; 2.727µs] or [-0.060%; +0.060%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 60480db 1727442793 julio/wait-for-child-processes
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 76.176µs 76.448µs ± 0.267µs 76.426µs ± 0.028µs 76.452µs 76.524µs 76.623µs 80.093µs 4.80% 12.886 173.401 0.35% 0.019µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [76.411µs; 76.484µs] or [-0.048%; +0.048%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 60480db 1727442793 julio/wait-for-child-processes
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 9.069ms 9.105ms ± 0.015ms 9.104ms ± 0.009ms 9.114ms 9.129ms 9.142ms 9.169ms 0.71% 0.602 1.434 0.16% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [9.103ms; 9.107ms] or [-0.022%; +0.022%] None None None

Baseline

Omitted due to size.

@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.85%. Comparing base (1d90886) to head (60480db).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #651      +/-   ##
==========================================
+ Coverage   73.82%   73.85%   +0.03%     
==========================================
  Files         257      257              
  Lines       37318    37301      -17     
==========================================
- Hits        27549    27548       -1     
+ Misses       9769     9753      -16
Components Coverage Δ
crashtracker 20.48% <ø> (-0.06%) ⬇️
crashtracker-ffi 9.28% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 93.33% <ø> (ø)
data-pipeline-ffi 0.00% <ø> (ø)
ddcommon 83.08% <ø> (ø)
ddcommon-ffi 69.52% <ø> (ø)
ddtelemetry 59.10% <ø> (ø)
ddtelemetry-ffi 22.13% <ø> (ø)
dogstatsd 90.42% <ø> (ø)
dogstatsd-client 79.77% <ø> (ø)
ipc 83.58% <ø> (ø)
profiling 84.26% <ø> (ø)
profiling-ffi 77.42% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 38.19% <ø> (ø)
sidecar-ffi 0.00% <ø> (ø)
spawn-worker 50.36% <ø> (ø)
tinybytes 94.77% <ø> (ø)
trace-mini-agent 72.47% <ø> (ø)
trace-normalization 98.25% <ø> (ø)
trace-obfuscation 95.73% <ø> (ø)
trace-protobuf 77.67% <ø> (ø)
trace-utils 93.87% <ø> (+0.40%) ⬆️

@hoolioh hoolioh changed the title Wait for spawn children Wait for spawned children Sep 26, 2024
@hoolioh hoolioh marked this pull request as ready for review September 26, 2024 14:42
@hoolioh hoolioh requested a review from a team as a code owner September 26, 2024 14:42
ekump
ekump approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@ekump ekump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - But can you just associate a JIRA ticket to this PR before merging?

@hoolioh hoolioh changed the title Wait for spawned children [APMSP-1391] Wait for spawned children Sep 26, 2024
@hoolioh hoolioh force-pushed the julio/wait-for-child-processes branch from 8a28d32 to ba13c1c Compare September 26, 2024 15:08
gleocadie
gleocadie approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@gleocadie gleocadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hoolioh hoolioh force-pushed the julio/wait-for-child-processes branch from ba13c1c to d80a2b9 Compare September 27, 2024 13:12
@hoolioh hoolioh force-pushed the julio/wait-for-child-processes branch from d80a2b9 to 60480db Compare September 27, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekump ekump ekump approved these changes

@gleocadie gleocadie gleocadie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hoolioh @codecov-commenter @ekump @gleocadie