Skip to content
This repository has been archived by the owner on Jun 28, 2022. It is now read-only.

[FEATURE] ddprof-profiles should compress profiles as it serializes them #21

Open
ivoanjo opened this issue Feb 7, 2022 · 1 comment

Comments

@ivoanjo
Copy link
Member

ivoanjo commented Feb 7, 2022

Is your feature request related to a problem? Please describe.
Currently, to report compressed profiles, the caller needs to manually compress the pprof data that is generated by ddprof-profiles before calling the exporter to report this data back to the backend.

Describe the goal of the feature
By having ddprof-profiles compress the data, the caller would no longer need to take care of this, and as a bonus side-effect memory usage during serialization would be reduced.

Describe alternatives you've considered
We could have the ddprof-exporter take care of the compression, but that means increased memory usage (because we would still need to hold the uncompressed pprof in memory).

@ivoanjo ivoanjo changed the title [FEATURE] ddprof-profiles should gzip profiles as it serializes them [FEATURE] ddprof-profiles should compress profiles as it serializes them Feb 7, 2022
@ivoanjo
Copy link
Member Author

ivoanjo commented Feb 7, 2022

Addendum: I initially specified gzip, but we probably should look into lz4 instead to minimize the cpu impact on the app being profiled.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant