This repository has been archived by the owner on Jun 28, 2022. It is now read-only.
Merge fixes for hyper certs #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawelchcki
approved these changes
Apr 11, 2022
pawelchcki
added a commit
that referenced
this pull request
Apr 13, 2022
* Proposal for refactoring of https connector to make root certificates optional * Tentative fix (#48) Co-authored-by: Nicolas Savoire <nicolas.savoire@datadoghq.com> * return error when HTTPs cannot be used but is requested * Correctly handle error when no root certificates are found * Use latest common multipart released package * Cleanup implementation + add tests * Fix linting errors * enable matrix build and test on all expected platforms * Rename MaybeHttpsConnector to Connector * Fix compilation on Windows * Make pin_project_lite usage compile on windows * Impl own pin project * Settle on using pin_project Co-authored-by: r1viollet <74836499+r1viollet@users.noreply.github.com> Co-authored-by: Nicolas Savoire <nicolas.savoire@datadoghq.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Merge changes from Pawel and Nicolas