Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add support for mapping new HTTP OTel semantic conventions #163

Closed
valkum opened this issue Sep 11, 2023 · 2 comments
Closed

Comments

@valkum
Copy link

valkum commented Sep 11, 2023

Previously, some keys from the semantic conventions of OTel had an overlap with Datadog's conventions (e.g. http.status_code).
With version 1.21 of the semantic conventions, this changed. http.status_code is now http.response.status_code.
While the new release contains the following:

SHOULD NOT change the version of the HTTP or networking attributes that they emit until the HTTP semantic conventions are marked stable (HTTP stabilization will include stabilization of a core set of networking attributes which are also used in HTTP instrumentations).

New libraries or ones that ignore this part won't work correctly with Datadog, at the moment.
I assume, as there is currently no mapper for HTTP, it can't hurt to add one right now to support new libraries.

I noticed that Datadog engineers are part of the OTel semantic conventions WG and wonder if Datadog is going to adapt the same semantics or not. Nevertheless, I think mapping HTTP requests for the time being would be a gain.

@masmontanas
Copy link

Would also greatly appreciate this as we're starting to run into issues with the latest versions of various otel packages.

@valkum
Copy link
Author

valkum commented Jul 17, 2024

The newest Datadog agent version now accepts stable OTel SemConv attribute names. See https://github.com/DataDog/datadog-agent/blob/main/CHANGELOG.rst#7540

@valkum valkum closed this as completed Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants