Skip to content

Commit

Permalink
Just be really sure we're using a debug image
Browse files Browse the repository at this point in the history
  • Loading branch information
tobz committed Sep 11, 2024
1 parent 752081c commit 59a5033
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
2 changes: 2 additions & 0 deletions .gitlab/benchmark.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ build-adp-baseline-image:
--tag ${BASELINE_SALUKI_IMG}
--build-arg BUILD_IMAGE=${SALUKI_BUILD_CI_IMAGE}
--build-arg APP_IMAGE=${GBI_BASE_IMAGE}
--build-arg BUILD_PROFILE=optimized-debug-release
--label git.repository=${CI_PROJECT_NAME}
--label git.branch=${CI_COMMIT_REF_NAME}
--label git.commit=${CI_COMMIT_SHA}
Expand Down Expand Up @@ -77,6 +78,7 @@ build-adp-comparison-image:
--tag ${COMPARISON_SALUKI_IMG}
--build-arg BUILD_IMAGE=${SALUKI_BUILD_CI_IMAGE}
--build-arg APP_IMAGE=${GBI_BASE_IMAGE}
--build-arg BUILD_PROFILE=optimized-debug-release
--label git.repository=${CI_PROJECT_NAME}
--label git.branch=${CI_COMMIT_REF_NAME}
--label git.commit=${CI_COMMIT_SHA}
Expand Down
8 changes: 7 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,12 @@ build-adp: ## Builds the ADP binary in release mode
@echo "[*] Building ADP locally..."
@cargo build --release --package agent-data-plane

.PHONY: build-adp-profiling
build-adp-profiling: check-rust-build-tools
build-adp-profiling: ## Builds the ADP binary for profiling (optimized-debug-release profile)
@echo "[*] Building ADP locally..."
@cargo build --profile optimized-debug-release --package agent-data-plane

.PHONY: build-adp-image
build-adp-image: ## Builds the ADP container image ('latest' tag)
@echo "[*] Building ADP image..."
Expand Down Expand Up @@ -351,7 +357,7 @@ endif
##@ Profiling

.PHONY: profile-run-adp-ddprof
profile-run-adp-ddprof: ensure-ddprof build-adp
profile-run-adp-ddprof: ensure-ddprof build-adp-profiling
profile-run-adp-ddprof: ## Runs ADP under ddprof locally
ifeq ($(shell test -S /var/run/datadog/apm.socket || echo not-found), not-found)
$(error "APM socket at /var/run/datadog/apm.socket not found. Is the Datadog Agent running?")
Expand Down

0 comments on commit 59a5033

Please sign in to comment.