Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to Datadog Metrics destination for shipping to multiple endpoints. #117

Open
Tracked by #114
tobz opened this issue Jul 17, 2024 · 1 comment
Open
Tracked by #114
Labels
area/io General I/O and networking. destination/datadog-metrics Datadog Metrics destination. effort/intermediate Involves changes that can be worked on by non-experts but might require guidance. type/enhancement An enhancement in functionality or support.

Comments

@tobz
Copy link
Member

tobz commented Jul 17, 2024

Currently, the Datadog Metrics destination does not support multiple endpoints, only the "main" endpoint as configured by either site or dd_url. The Datadog Agent does support multiple endpoints through its general additional_endpoints configuration scheme, used across logs and metrics for configuring additional endpoints to dual (or triple! etc) ship to.

We should:

  • add support for dual shipping (this should also use tower, but there's no existing tower middleware for fanning out a request, so we'll have to write that ourselves, and take care around making request cloning cheap)
  • match the existing additional_endpoints configuration in the Datadog Agent's forwarder
@tobz tobz changed the title chore(datadog_metrics destination): add support for shipping to multiple endpoints Add support to Datadog Metrics destination for shipping to multiple endpoints. Jul 17, 2024
@tobz tobz added area/io General I/O and networking. effort/intermediate Involves changes that can be worked on by non-experts but might require guidance. destination/datadog-metrics Datadog Metrics destination. type/enhancement An enhancement in functionality or support. labels Jul 17, 2024
@tobz tobz added this to the ADP v0.2: Staging Ahoy milestone Aug 13, 2024
@tobz
Copy link
Member Author

tobz commented Sep 26, 2024

As a note, since it just occurred to me: we'll want to make sure that this takes advantage of ReplayBody<B> which we utilize to efficiently support retries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/io General I/O and networking. destination/datadog-metrics Datadog Metrics destination. effort/intermediate Involves changes that can be worked on by non-experts but might require guidance. type/enhancement An enhancement in functionality or support.
Projects
None yet
Development

No branches or pull requests

1 participant