Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that our aggregation behavior matches that of the Datadog Agent. #157

Closed
Tracked by #156
tobz opened this issue Aug 8, 2024 · 1 comment
Closed
Tracked by #156
Labels
area/components Sources, transforms, and destinations. effort/simple Involves trivial changes that should be fine so long as the code compiles and tests pass. good first issue Good for newcomers type/chore Updates to dependencies or general "administrative" tasks necessary to maintain the codebase/repo.

Comments

@tobz
Copy link
Member

tobz commented Aug 8, 2024

Context

We'd like to double check the behavior of the Aggregate transform compared to the Agent's aggregator.

Here's a non-exhaustive list of things, in no specific order:

  • timing (how flush windows are aligned, the width of those windows)
  • "zero value" counters/rates (how they're determined, which flush window they fall into, expiration behavior)
@tobz tobz added good first issue Good for newcomers area/components Sources, transforms, and destinations. effort/simple Involves trivial changes that should be fine so long as the code compiles and tests pass. type/chore Updates to dependencies or general "administrative" tasks necessary to maintain the codebase/repo. labels Aug 8, 2024
@tobz tobz added this to the ADP v0.2: Staging Ahoy milestone Aug 13, 2024
@tobz
Copy link
Member Author

tobz commented Sep 5, 2024

I believe that between #210, #215, and #217, this is now fixed/taken care of.

@tobz tobz closed this as completed Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/components Sources, transforms, and destinations. effort/simple Involves trivial changes that should be fine so long as the code compiles and tests pass. good first issue Good for newcomers type/chore Updates to dependencies or general "administrative" tasks necessary to maintain the codebase/repo.
Projects
None yet
Development

No branches or pull requests

1 participant