Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump rustls from 0.23.12 to 0.23.13 #248

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 16, 2024

Bumps rustls from 0.23.12 to 0.23.13.

Commits
  • a8d875f Prepare 0.23.13
  • bc892cd kx: work around aws-lc-rs accepting more point formats
  • 9730181 Take aws-lc-rs 1.9 and enable prebuilt-nasm
  • 1376edd fix(deps): update rust crate zlib-rs to 0.3
  • 696a1ef added links to rustls-wolfcrypt-provider in the third-party crypto providers ...
  • f05b0cc validate_ffdhe_params: also validate constants
  • 37af3c1 Override default ffdhe_group() for all kx impls
  • 92ff3d8 Deprecate and remove use of FfdheGroup::named_group
  • 483fece Deprecate and remove use of FfdheGroup::from_named_group
  • 97191e0 Have key exchange types know their FFDHE group
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner September 16, 2024 15:46
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Sep 16, 2024
@dependabot dependabot bot requested a review from a team as a code owner September 16, 2024 15:46
@dependabot dependabot bot added the rust Pull requests that update Rust code label Sep 16, 2024
@pr-commenter
Copy link

pr-commenter bot commented Sep 16, 2024

Regression Detector (DogStatsD)

Regression Detector Results

Run ID: 7ad14130-590b-440e-b0db-46e9c4fb28b3

Baseline: 7.55.2
Comparison: 7.55.3

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
dsd_uds_100mb_3k_contexts_distributions_only memory utilization +0.87 [+0.69, +1.05] 1
dsd_uds_1mb_50k_contexts ingress throughput +0.02 [-0.03, +0.06] 1
dsd_uds_1mb_3k_contexts ingress throughput +0.02 [-0.03, +0.06] 1
dsd_uds_512kb_3k_contexts ingress throughput +0.00 [-0.05, +0.05] 1
dsd_uds_500mb_3k_contexts ingress throughput -0.00 [-0.01, +0.01] 1
dsd_uds_100mb_250k_contexts ingress throughput -0.00 [-0.04, +0.03] 1
dsd_uds_100mb_3k_contexts ingress throughput -0.02 [-0.05, +0.01] 1
dsd_uds_10mb_3k_contexts ingress throughput -0.03 [-0.06, +0.01] 1
dsd_uds_1mb_50k_contexts_memlimit ingress throughput -0.03 [-0.07, +0.01] 1

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@pr-commenter
Copy link

pr-commenter bot commented Sep 16, 2024

Regression Detector (Saluki)

Regression Detector Results

Run ID: b23639aa-de83-4606-a7a1-80403de9cf69

Baseline: ec4959e
Comparison: 083fdd0

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
dsd_uds_100mb_3k_contexts ingress throughput +0.00 [-0.02, +0.03] 1
dsd_uds_512kb_3k_contexts ingress throughput +0.00 [-0.16, +0.16] 1
dsd_uds_50mb_10k_contexts_no_inlining ingress throughput +0.00 [-0.00, +0.00] 1
dsd_uds_1mb_3k_contexts ingress throughput +0.00 [-0.03, +0.03] 1
dsd_uds_50mb_10k_contexts_no_inlining_no_allocs ingress throughput -0.00 [-0.02, +0.02] 1
dsd_uds_10mb_3k_contexts ingress throughput -0.00 [-0.05, +0.04] 1
dsd_uds_1mb_50k_contexts ingress throughput -0.02 [-0.03, -0.00] 1
dsd_uds_100mb_250k_contexts ingress throughput -0.03 [-0.28, +0.22] 1
dsd_uds_1mb_50k_contexts_memlimit ingress throughput -0.26 [-3.48, +2.95] 1
dsd_uds_500mb_3k_contexts ingress throughput -0.91 [-1.01, -0.81] 1
dsd_uds_100mb_3k_contexts_distributions_only memory utilization -3.02 [-3.21, -2.84] 1

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@pr-commenter
Copy link

pr-commenter bot commented Sep 16, 2024

Regression Detector Links

Experiment Result Links

experiment link(s)
dsd_uds_100mb_250k_contexts [Profiling (ADP)] [Profiling (DSD)] [SMP Dashboard]
dsd_uds_100mb_3k_contexts [Profiling (ADP)] [Profiling (DSD)] [SMP Dashboard]
dsd_uds_100mb_3k_contexts_distributions_only [Profiling (ADP)] [Profiling (DSD)] [SMP Dashboard]
dsd_uds_10mb_3k_contexts [Profiling (ADP)] [Profiling (DSD)] [SMP Dashboard]
dsd_uds_1mb_3k_contexts [Profiling (ADP)] [Profiling (DSD)] [SMP Dashboard]
dsd_uds_1mb_50k_contexts [Profiling (ADP)] [Profiling (DSD)] [SMP Dashboard]
dsd_uds_1mb_50k_contexts_memlimit [Profiling (ADP)] [Profiling (DSD)] [SMP Dashboard]
dsd_uds_500mb_3k_contexts [Profiling (ADP)] [Profiling (DSD)] [SMP Dashboard]
dsd_uds_512kb_3k_contexts [Profiling (ADP)] [Profiling (DSD)] [SMP Dashboard]
dsd_uds_50mb_10k_contexts_no_inlining (ADP only) [Profiling (ADP)] [SMP Dashboard]
dsd_uds_50mb_10k_contexts_no_inlining_no_allocs (ADP only) [Profiling (ADP)] [SMP Dashboard]

Bumps [rustls](https://github.com/rustls/rustls) from 0.23.12 to 0.23.13.
- [Release notes](https://github.com/rustls/rustls/releases)
- [Changelog](https://github.com/rustls/rustls/blob/main/CHANGELOG.md)
- [Commits](rustls/rustls@v/0.23.12...v/0.23.13)

---
updated-dependencies:
- dependency-name: rustls
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/cargo/rustls-0.23.13 branch from 6671989 to 083fdd0 Compare September 25, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants