Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test ubuntu 18 ARM #3118

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

test ubuntu 18 ARM #3118

wants to merge 4 commits into from

Conversation

emmettbutler
Copy link
Contributor

@emmettbutler emmettbutler commented Sep 24, 2024

This pull request adds Ubuntu 18 arm64 to the list of operating systems tested with auto-instrumentation.

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@emmettbutler emmettbutler requested a review from a team as a code owner September 24, 2024 18:40
@emmettbutler emmettbutler marked this pull request as draft September 24, 2024 18:40
@emmettbutler emmettbutler marked this pull request as ready for review September 24, 2024 20:30
Copy link
Collaborator

@robertomonteromiguel robertomonteromiguel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You added the ubuntu 18 arm vm as not default vm, it is not going to execute on "extra vms" job.
Running other jobs I see this error:
06:37:03.584 INFO * creating EC2 Instance: InvalidParameterValue: The t2.medium instance type does not support an AMI with a boot mode of UEFI. Only instance types built on the Nitro System support UEFI. Specify an instance type that supports UEFI, and try again.
The arm vms should be of type "t4g.small"

@emmettbutler
Copy link
Contributor Author

@robertomonteromiguel

You added the ubuntu 18 arm vm as not default vm, it is not going to execute on "extra vms" job.

I don't see the difference between this change and how I approached the Fedora change. What do I need to change on this PR?

Copy link
Collaborator

@robertomonteromiguel robertomonteromiguel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to choose another AMI, because this one requires a subscription:

06:41:04.772 INFO aws:ec2:Instance (Ubuntu_18_arm64): 06:41:04.772 INFO error: 1 error occurred: 06:41:04.773 INFO * creating EC2 Instance: OptInRequired: In order to use this AWS Marketplace product you need to accept terms and subscribe. To do so please visit https://aws.amazon.com/marketplace/pp?sku=c32m5ohwwfzz4h6g2anowwufo 06:41:04.773 INFO status code: 401, request id: 6f963b00-0c57-45a9-bb3e-21f185c654bf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants