Fix CI and Rails 7.1 compatibility on main #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stable builds: - Test against Ruby 3.3 stable - Test against Rails 7.1 stable - Test against Rails 7.2 beta Experimental builds: - Test against Rails edge (previously: 7.1, ref: DatabaseCleaner#106) - Test against Ruby head Fixes: - Fix sqlite3 dependency on old Rails versions Updates: - Update GitHub actions Readability: - Sort and group inclusion and exclusions in CI matrix
Also: - Invert the logic to make the conditional more readable - Add "alpha" to version to include pre-releases ActiveRecord: - 7.2: `Base.connection_pool.schema_migration.table_name` - 7.1, 7.0, 6.x: `Base.connection.schema_migration.table_name` - 5.x: `SchemaMigration.table_name` Close DatabaseCleaner#106
Removes dependency on version
tagliala
commented
Jun 11, 2024
Comment on lines
-18
to
+20
| if Gem::Version.new("7.1.0") < ::ActiveRecord.version | ||
| if ::ActiveRecord::Base.connection_pool.respond_to?(:schema_migration) # Rails >= 7.2 | ||
| ::ActiveRecord::Base.connection_pool.schema_migration.table_name | ||
| elsif Gem::Version.new("6.0.0") <= ::ActiveRecord.version | ||
| elsif ::ActiveRecord::Base.connection.respond_to?(:schema_migration) # Rails >= 6.0 |
There was a problem hiding this comment.
opinionated change in a separate commit, feel free to remove the last commit to use a version-based comparison.
As a side node, these changes are introduced in alphas, betas, and even RCs, so I prefer respond_to? instead of relying on the version
|
This fixes a bug that's currently affecting people. It would be fantastic if this were released. |
etagwerker
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve CI
Stable builds:
Experimental builds:
Fixes:
Updates:
Readability:
Fix Rails 7.1 compatibility
Also:
ActiveRecord:
Base.connection_pool.schema_migration.table_nameBase.connection.schema_migration.table_nameSchemaMigration.table_nameUse
respond_to?to determine the schema migration table nameClose #106