You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have been using your library successfully several months - maybe over year in Espressif32 framework. Most I have been using Espressif32 version 3.5, but now I am going to 6.1. You could have mention that it works also on that framework.
Some succestions:
Could ESP_LOGE be ESP_LOGD instead? I do not see why e.g., "rx_items == 0" would be an error. It is normal that 1-wire line can be empty.
In library.json you could have "frameworks": ["espidf","arduino"],
There is not much changed from version 3 -> 5 or 6. Could there be conditional compiling to keep same source still for older version? e.g.,
Yes, I'd be happy to consider a PR. Your three points seem OK to me, although I don't really want to support IDF v3.x actively. But if you think it would be useful to keep it working for 3.x, then your third point would be OK, if you're able to test it. There may be other things that break with 3.x however, especially as we're moving to the new RMT interface soon.
I have been using your library successfully several months - maybe over year in Espressif32 framework. Most I have been using Espressif32 version 3.5, but now I am going to 6.1. You could have mention that it works also on that framework.
Some succestions:
I can also make PR, if you agree my improvements.
The text was updated successfully, but these errors were encountered: