Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In chameleon-light.css, palette-text-lighter1 and palette-text-darker1 are defined opposit to the name (lighter=darker and darker=lighter) #3

Open
rthemans opened this issue Nov 25, 2024 · 0 comments

Comments

@rthemans
Copy link

First and foremost !!Thank you!!

That’s a really great theme for TriliumNext.
It’s easy to configure and the variable naming makes it really easy to understand! (Hence my discovery ;-) )

I was really searching for one so thank you already!!

Explanation

I like my headers to be darker in "dark" mode and lighter in "light" mode than the normal text.
In the dark version of the theme, I could just add:
--bs-heading-color: var(--palette-text-darker1);
When I tried to do the same in the light mode with:
--bs-heading-color: var(--palette-text-lighter1);
It actually went darker.

I checked the code and his history in this repo and this seems to have always been as described below.

Note sure if there is something intended or not there but it would still make more sense to have the variable name aligned with its behavior ;-)

Current

--palette-text-lighter1: hsl(
    230,
    10%,
    calc(var(--palette-text-brightness) - 20%)
  );

--palette-text-darker1: hsl(
    230,
    10%,
    calc(var(--palette-text-brightness) + 20%)
  );

Expected

--palette-text-lighter1: hsl(
    230,
    10%,
    calc(var(--palette-text-brightness) + 20%)
  );

--palette-text-darker1: hsl(
    230,
    10%,
    calc(var(--palette-text-brightness) - 20%)
  );
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant