Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DialogOutlet doesn't work properly #60

Open
ilajosmanov opened this issue Aug 22, 2024 · 5 comments
Open

DialogOutlet doesn't work properly #60

ilajosmanov opened this issue Aug 22, 2024 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@ilajosmanov
Copy link

Hi! Thank you so much for this library, very useful!

I've found some issue, when use <Dialog /> component wrapped by Transition. Dialog appears in the place where it was created but not inside DialogOutlet itself.
Am I doing something wrong?

Code example:

// App.blazor

<DialogOutlet />
// SomeComponent.razor

<Transition>
  <Dialog />
</Transition>
@DavidVollmers
Copy link
Owner

Hi, thanks for using Ignis!

This might actually be a bug you encountered, I will have to test this properly.

Does it work for you if you render the transition as a Fragment like this:

<Transition AsComponent="typeof(Fragment)">
  <Dialog />
</Transition>

@DavidVollmers DavidVollmers self-assigned this Aug 22, 2024
@ilajosmanov
Copy link
Author

ilajosmanov commented Aug 22, 2024

Sorry for confusion, but yes - my code looks like here:
<Transition Appear="@Appear" Show="IsOpen" AsComponent="typeof(Fragment)" Context="_" />
it still doesn't work. Let me know if I can provide more details.

@DavidVollmers
Copy link
Owner

If you could provide an example repository where you reproduce this behavior it would be really helpful!

@DavidVollmers DavidVollmers added the bug Something isn't working label Aug 23, 2024
@ilajosmanov
Copy link
Author

Don't worry! I could fix it.
I put <DialogOutlet /> into component (like header for example) with @rendermode InteractiveAuto and then it works.

p.s If your app isn't InteractiveAuto globally, you shouldn't put it into <App.razor/>. I think, it should be added to the docs. (I'm new, so it wasn't so obvious). If you want - I can make a PR :)

@DavidVollmers
Copy link
Owner

Interesting! Thanks for the analysis. I will have a deeper look into this to understand exactly what the problem here is and then either fix it or document it as you described!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants