Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invert arc labels #26

Open
J7mbo opened this issue Sep 14, 2023 · 2 comments
Open

Invert arc labels #26

J7mbo opened this issue Sep 14, 2023 · 2 comments

Comments

@J7mbo
Copy link

J7mbo commented Sep 14, 2023

Hi! Firstly, thank you for taking over this library. It's super useful (and is teaching me a lot about charts, haven't really used them before this).

There is an open pull request (code here) in the unmaintained version of this lib that flips the labels underneath the arcs where the text would otherwise be upside down. However, this code is no longer compatible with the updates you've made to this lib, so it's not easy for me to migrate over.

Please would you consider porting this to allow the text to be flipped at the bottom of the arc? Or is this functionality already in here somewhere?

@J7mbo
Copy link
Author

J7mbo commented Sep 14, 2023

Actually, the code does just paste over and work as nothing is modified here. Must've been looking at another library. I would try and put in a PR but I'm guessing you would like this as an option not a default; how would you like to do that (If there's any interest in this feature anyway).

@DavideViolante
Copy link
Owner

The code is not so different from the old repo, I think you can open a PR here and I will check it out. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants