Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply Minimum Spell Hit Chance #490

Closed
wants to merge 1 commit into from

Conversation

tegstewart
Copy link
Contributor

We're correctly reducing spell damage when spell hit chance is below the 55% minimum, but were then incorrectly using the <55% hit chance.

Only having a 40% chance to hit Gjal with a spell and then also having damage reduced by 64.5% on top of that is just mean.

We're correctly reducing spell damage when spell hit chance is below the 55% minimum, but were then incorrectly using the <55% hit chance.

Only having a 40% chance to hit Gjal with a spell and then also having damage reduced by 64.5% on top of that is just mean.
@tegstewart
Copy link
Contributor Author

Bah, Tolakram's notes seem to indicate that 55% claim is flat out not true. Blech.

I know other private servers went with the 55% cap, so I'm now wondering if this should be a server property, disabled by default.

@NetDwarf
Copy link
Contributor

NetDwarf commented Nov 8, 2024

Would that mean that a spell would resist with a chance of maxResistChance at most for any mob (even a dragon) as the name suggests?

The double disadvantage against high level mobs is intended. I can say that it is at least not totally un-livelike for the most common cases. It might even be too weak for very high mobs like dragons as even a group of players were mostly unable to hit these with spells without pet spam.

@tegstewart
Copy link
Contributor Author

I'll close this, then. Wish I'd noticed Tolak's notes before PRing, but they're in a different part of the file than I was working on.

It's not really a problem, anyway. People can reduce or remove the damage penalty via existing server properties anyway.

@tegstewart tegstewart closed this Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants