Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the ability to execute the main plugin functionality directly #18

Closed
Potherca opened this issue Feb 17, 2017 · 6 comments
Closed
Assignees
Milestone

Comments

@Potherca
Copy link
Member

Problem/Motivation

The main functionality of this plugin (installing a custom code sniff) can be called separately (see isue #4).
However, this functionality has not (yet) been documented. It could be useful for users to be made aware of this feature in the documentation.

Expected behaviour / Actual behaviour / Steps to reproduce

Does not apply

Proposed changes

Document what the future is and how it can be used.

@Potherca Potherca added this to the v0.4.0 milestone Feb 17, 2017
@Potherca Potherca self-assigned this Feb 17, 2017
@Wirone
Copy link

Wirone commented Feb 17, 2017

Before making docs consider refactoring of plugin's class and entry point method's names. In my opinion they're not descriptive, especially the latter.

Both (class and method) should be named in a way like Incenteev\\ParameterHandler\\ScriptHandler::buildParameters or Sensio\\Bundle\\DistributionBundle\\Composer\\ScriptHandler::clearCache.

Maybe Dealerdirect\\Composer\\Plugin\\Installers\\PHPCodeSniffer\\PHPCompatibilityPlugin::installSniffs?

For backward compatibility you can then extend Dealerdirect\Composer\Plugin\Installers\PHPCodeSniffer\PHPCompatibilityPlugin with Dealerdirect\Composer\Plugin\Installers\PHPCodeSniffer\Plugin and use Plugin::run() to call PHPCompatibilityPlugin::installSniffs(). In future versions this could be deprecated and removed.

@Potherca
Copy link
Member Author

Valid point, will clarify the method name. As naming a thing is hard, @frenck: do you have any quams about PHPCompatibilityPlugin::installSniffs()?

@frenck
Copy link
Contributor

frenck commented Feb 17, 2017

@Potherca nope, I agree with @Wirone.
I feel like we need another separate issue for this.

@Wirone
Copy link

Wirone commented Feb 17, 2017

Now when I think of it, it should not be named PHPCompatibilityPlugin since it's not only about PHPCompatibility, but any custom standard, right?

So maybe CustomStandardsPlugin::installStandards()?

We all know phrase about naming and invalidating cache 🤣

@Potherca
Copy link
Member Author

Added documentation to the README, leaving the method/class rename for another issue.

@Potherca
Copy link
Member Author

Resolved by #29 will be included in the upcoming v0.4 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants