Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add or update component needed by France #242

Closed
sulli-a opened this issue May 3, 2023 · 1 comment
Closed

Add or update component needed by France #242

sulli-a opened this issue May 3, 2023 · 1 comment
Assignees
Labels
components 🧩 Related to components enhancement 🚀 New feature or request

Comments

@sulli-a
Copy link

sulli-a commented May 3, 2023

Context

France needs to use a formatting component on landing pages which currently does not seem to exist, the need is to display a banner.

We would like to propose an evolution of the card component or maybe a new component, what do you think of this idea?

The following design was made: https://www.figma.com/file/bN6HFumEOBw2Voh3o429G5/Composant-Nemo?type=design&node-id=1-3698&t=XIrHQYSaOATLBG4E-0

Challenges

The challenge is to integrate this component into the Nemo solution (CMS) and do it on the core side (not a country override)

@lauthieb lauthieb added enhancement 🚀 New feature or request components 🧩 Related to components labels May 3, 2023
@MARIEDELATTRE
Copy link
Contributor

Hi @sulli-a thanks for your contribution. As discussed with the Vitamin team the actual version of the Vitamin card doesn't cover the cases you need. Unfortunately as mentionned in our last communication we maintain the actual version on Vitamin, so we can fix bugs or add icons, thus we won't develop new variants or components. But we're convinced that those variants improve the card component and it's why we decided to implement them in the future version of Vitamin (which will be available with the actuel look&feel and also with another theme for new brand look&feel). I linked this issue in our board of the new version.

@MARIEDELATTRE MARIEDELATTRE closed this as not planned Won't fix, can't repro, duplicate, stale May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
components 🧩 Related to components enhancement 🚀 New feature or request
Projects
Archived in project
Development

No branches or pull requests

3 participants