Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve tests for grids #276

Closed
2 tasks done
gcroci2 opened this issue Dec 13, 2022 · 2 comments · Fixed by #420
Closed
2 tasks done

Improve tests for grids #276

gcroci2 opened this issue Dec 13, 2022 · 2 comments · Fixed by #420
Labels
CI continuous integration Query query module related issues

Comments

@gcroci2
Copy link
Collaborator

gcroci2 commented Dec 13, 2022 •
edited
Loading

In test_graph.py, we should separate tests for (being graph a Graph object):

  • graph.write_to_hdf5()
  • graph.write_as_grid_to_hdf5()
@gcroci2 gcroci2 added priority Solve this first and removed priority Solve this first labels Dec 13, 2022
@github-actions
Copy link

This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the stale issue not touched from too much time label Jan 13, 2023
@gcroci2 gcroci2 removed the stale issue not touched from too much time label Jan 13, 2023
@github-actions
Copy link

This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the stale issue not touched from too much time label Feb 17, 2023
@gcroci2 gcroci2 added priority Solve this first and removed priority Solve this first labels Mar 3, 2023
@gcroci2 gcroci2 added Query query module related issues priority Solve this first labels Apr 26, 2023
@DaniBodor DaniBodor added the CI continuous integration label Apr 26, 2023
@gcroci2 gcroci2 changed the title Test properly graph build and export Improve tests for grids Apr 26, 2023
@gcroci2 gcroci2 linked a pull request May 2, 2023 that will close this issue
test: improve utils/test_graph.py module #420
Merged
@gcroci2 gcroci2 removed stale issue not touched from too much time priority Solve this first labels May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI continuous integration Query query module related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: improve utils/test_graph.py module DeepRank/deeprank2
2 participants
@DaniBodor @gcroci2