From eac6d76eb2019022fd568687a2c5a4c90c857448 Mon Sep 17 00:00:00 2001 From: alexeys Date: Thu, 27 Feb 2020 15:29:48 +0500 Subject: [PATCH 1/2] #8 // explicitly pass root to dcFactory.init method --- README.md | 8 ++++---- demo/dist/dc.min.js | 2 +- demo/dist/dc.min.js.map | 2 +- index.html | 4 ++-- src/dc-factory.js | 7 ++++++- 5 files changed, 14 insertions(+), 9 deletions(-) diff --git a/README.md b/README.md index 5678fb6..25cb613 100644 --- a/README.md +++ b/README.md @@ -45,7 +45,7 @@ dcFactory.register(CollapsedComponent); // later after registering all your components, when your page is ready -dcFactory.init(); +dcFactory.init(document.body); ``` @@ -67,13 +67,13 @@ Type: `string` CSS selector which will override searching by getNamespace() and be used for searching elements of given componentClass. -### dcFactory.init(root = document.body, withLazy = true) +### dcFactory.init(root, withLazy = true) Starts the factory on a given root: finds and creates all registered components within the root #### root -*Optional*
+*Required*
Type: `HTMLElement` #### withLazy @@ -139,4 +139,4 @@ Type: `HTMLElement` ## License -[MIT](https://choosealicense.com/licenses/mit/) \ No newline at end of file +[MIT](https://choosealicense.com/licenses/mit/) diff --git a/demo/dist/dc.min.js b/demo/dist/dc.min.js index 55421e7..66876bf 100644 --- a/demo/dist/dc.min.js +++ b/demo/dist/dc.min.js @@ -1,2 +1,2 @@ -!function(t,n){if("object"==typeof exports&&"object"==typeof module)module.exports=n();else if("function"==typeof define&&define.amd)define([],n);else{var e=n();for(var r in e)("object"==typeof exports?exports:t)[r]=e[r]}}(window,(function(){return function(t){var n={};function e(r){if(n[r])return n[r].exports;var o=n[r]={i:r,l:!1,exports:{}};return t[r].call(o.exports,o,o.exports,e),o.l=!0,o.exports}return e.m=t,e.c=n,e.d=function(t,n,r){e.o(t,n)||Object.defineProperty(t,n,{enumerable:!0,get:r})},e.r=function(t){"undefined"!=typeof Symbol&&Symbol.toStringTag&&Object.defineProperty(t,Symbol.toStringTag,{value:"Module"}),Object.defineProperty(t,"__esModule",{value:!0})},e.t=function(t,n){if(1&n&&(t=e(t)),8&n)return t;if(4&n&&"object"==typeof t&&t&&t.__esModule)return t;var r=Object.create(null);if(e.r(r),Object.defineProperty(r,"default",{enumerable:!0,value:t}),2&n&&"string"!=typeof t)for(var o in t)e.d(r,o,function(n){return t[n]}.bind(null,o));return r},e.n=function(t){var n=t&&t.__esModule?function(){return t.default}:function(){return t};return e.d(n,"a",n),n},e.o=function(t,n){return Object.prototype.hasOwnProperty.call(t,n)},e.p="",e(e.s=70)}([function(t,n,e){var r=e(25)("wks"),o=e(17),i=e(4).Symbol,u="function"==typeof i;(t.exports=function(t){return r[t]||(r[t]=u&&i[t]||(u?i:o)("Symbol."+t))}).store=r},function(t,n,e){var r=e(2);t.exports=function(t){if(!r(t))throw TypeError(t+" is not an object!");return t}},function(t,n){t.exports=function(t){return"object"==typeof t?null!==t:"function"==typeof t}},function(t,n,e){t.exports=!e(7)((function(){return 7!=Object.defineProperty({},"a",{get:function(){return 7}}).a}))},function(t,n){var e=t.exports="undefined"!=typeof window&&window.Math==Math?window:"undefined"!=typeof self&&self.Math==Math?self:Function("return this")();"number"==typeof __g&&(__g=e)},function(t,n,e){var r=e(1),o=e(42),i=e(29),u=Object.defineProperty;n.f=e(3)?Object.defineProperty:function(t,n,e){if(r(t),n=i(n,!0),r(e),o)try{return u(t,n,e)}catch(t){}if("get"in e||"set"in e)throw TypeError("Accessors not supported!");return"value"in e&&(t[n]=e.value),t}},function(t,n,e){var r=e(4),o=e(8),i=e(9),u=e(17)("src"),c=e(71),a=(""+c).split("toString");e(15).inspectSource=function(t){return c.call(t)},(t.exports=function(t,n,e,c){var s="function"==typeof e;s&&(i(e,"name")||o(e,"name",n)),t[n]!==e&&(s&&(i(e,u)||o(e,u,t[n]?""+t[n]:a.join(String(n)))),t===r?t[n]=e:c?t[n]?t[n]=e:o(t,n,e):(delete t[n],o(t,n,e)))})(Function.prototype,"toString",(function(){return"function"==typeof this&&this[u]||c.call(this)}))},function(t,n){t.exports=function(t){try{return!!t()}catch(t){return!0}}},function(t,n,e){var r=e(5),o=e(16);t.exports=e(3)?function(t,n,e){return r.f(t,n,o(1,e))}:function(t,n,e){return t[n]=e,t}},function(t,n){var e={}.hasOwnProperty;t.exports=function(t,n){return e.call(t,n)}},function(t,n,e){var r=e(72);t.exports=function(t,n,e){if(r(t),void 0===n)return t;switch(e){case 1:return function(e){return t.call(n,e)};case 2:return function(e,r){return t.call(n,e,r)};case 3:return function(e,r,o){return t.call(n,e,r,o)}}return function(){return t.apply(n,arguments)}}},function(t,n,e){var r=e(32),o=e(23);t.exports=function(t){return r(o(t))}},function(t,n,e){var r=e(22),o=Math.min;t.exports=function(t){return t>0?o(r(t),9007199254740991):0}},function(t,n,e){var r=e(23);t.exports=function(t){return Object(r(t))}},function(t,n,e){var r=e(4),o=e(15),i=e(8),u=e(6),c=e(10),a=function(t,n,e){var s,f,l,p,v=t&a.F,h=t&a.G,y=t&a.S,d=t&a.P,g=t&a.B,m=h?r:y?r[n]||(r[n]={}):(r[n]||{}).prototype,b=h?o:o[n]||(o[n]={}),_=b.prototype||(b.prototype={});for(s in h&&(e=n),e)l=((f=!v&&m&&void 0!==m[s])?m:e)[s],p=g&&f?c(l,r):d&&"function"==typeof l?c(Function.call,l):l,m&&u(m,s,l,t&a.U),b[s]!=l&&i(b,s,p),d&&_[s]!=l&&(_[s]=l)};r.core=o,a.F=1,a.G=2,a.S=4,a.P=8,a.B=16,a.W=32,a.U=64,a.R=128,t.exports=a},function(t,n){var e=t.exports={version:"2.6.10"};"number"==typeof __e&&(__e=e)},function(t,n){t.exports=function(t,n){return{enumerable:!(1&t),configurable:!(2&t),writable:!(4&t),value:n}}},function(t,n){var e=0,r=Math.random();t.exports=function(t){return"Symbol(".concat(void 0===t?"":t,")_",(++e+r).toString(36))}},function(t,n){t.exports={}},function(t,n,e){var r=e(46),o=e(35);t.exports=Object.keys||function(t){return r(t,o)}},function(t,n,e){var r=e(17)("meta"),o=e(2),i=e(9),u=e(5).f,c=0,a=Object.isExtensible||function(){return!0},s=!e(7)((function(){return a(Object.preventExtensions({}))})),f=function(t){u(t,r,{value:{i:"O"+ ++c,w:{}}})},l=t.exports={KEY:r,NEED:!1,fastKey:function(t,n){if(!o(t))return"symbol"==typeof t?t:("string"==typeof t?"S":"P")+t;if(!i(t,r)){if(!a(t))return"F";if(!n)return"E";f(t)}return t[r].i},getWeak:function(t,n){if(!i(t,r)){if(!a(t))return!0;if(!n)return!1;f(t)}return t[r].w},onFreeze:function(t){return s&&l.NEED&&a(t)&&!i(t,r)&&f(t),t}}},function(t,n,e){var r=e(2);t.exports=function(t,n){if(!r(t)||t._t!==n)throw TypeError("Incompatible receiver, "+n+" required!");return t}},function(t,n){var e=Math.ceil,r=Math.floor;t.exports=function(t){return isNaN(t=+t)?0:(t>0?r:e)(t)}},function(t,n){t.exports=function(t){if(null==t)throw TypeError("Can't call method on "+t);return t}},function(t,n){t.exports=!1},function(t,n,e){var r=e(15),o=e(4),i=o["__core-js_shared__"]||(o["__core-js_shared__"]={});(t.exports=function(t,n){return i[t]||(i[t]=void 0!==n?n:{})})("versions",[]).push({version:r.version,mode:e(24)?"pure":"global",copyright:"© 2019 Denis Pushkarev (zloirock.ru)"})},function(t,n,e){var r=e(5).f,o=e(9),i=e(0)("toStringTag");t.exports=function(t,n,e){t&&!o(t=e?t:t.prototype,i)&&r(t,i,{configurable:!0,value:n})}},function(t,n){n.f={}.propertyIsEnumerable},function(t,n,e){var r=e(5).f,o=Function.prototype,i=/^\s*function ([^ (]*)/;"name"in o||e(3)&&r(o,"name",{configurable:!0,get:function(){try{return(""+this).match(i)[1]}catch(t){return""}}})},function(t,n,e){var r=e(2);t.exports=function(t,n){if(!r(t))return t;var e,o;if(n&&"function"==typeof(e=t.toString)&&!r(o=e.call(t)))return o;if("function"==typeof(e=t.valueOf)&&!r(o=e.call(t)))return o;if(!n&&"function"==typeof(e=t.toString)&&!r(o=e.call(t)))return o;throw TypeError("Can't convert object to primitive value")}},function(t,n,e){"use strict";var r=e(24),o=e(14),i=e(6),u=e(8),c=e(18),a=e(73),s=e(26),f=e(78),l=e(0)("iterator"),p=!([].keys&&"next"in[].keys()),v=function(){return this};t.exports=function(t,n,e,h,y,d,g){a(e,n,h);var m,b,_,x=function(t){if(!p&&t in O)return O[t];switch(t){case"keys":case"values":return function(){return new e(this,t)}}return function(){return new e(this,t)}},S=n+" Iterator",w="values"==y,E=!1,O=t.prototype,k=O[l]||O["@@iterator"]||y&&O[y],C=k||x(y),j=y?w?x("entries"):C:void 0,A="Array"==n&&O.entries||k;if(A&&(_=f(A.call(new t)))!==Object.prototype&&_.next&&(s(_,S,!0),r||"function"==typeof _[l]||u(_,l,v)),w&&k&&"values"!==k.name&&(E=!0,C=function(){return k.call(this)}),r&&!g||!p&&!E&&O[l]||u(O,l,C),c[n]=C,c[S]=v,y)if(m={values:w?C:x("values"),keys:d?C:x("keys"),entries:j},g)for(b in m)b in O||i(O,b,m[b]);else o(o.P+o.F*(p||E),n,m);return m}},function(t,n,e){var r=e(1),o=e(74),i=e(35),u=e(34)("IE_PROTO"),c=function(){},a=function(){var t,n=e(43)("iframe"),r=i.length;for(n.style.display="none",e(77).appendChild(n),n.src="javascript:",(t=n.contentWindow.document).open(),t.write(" diff --git a/src/dc-factory.js b/src/dc-factory.js index 3823858..40109df 100644 --- a/src/dc-factory.js +++ b/src/dc-factory.js @@ -99,7 +99,12 @@ class DcFactory { * @param {HTMLElement} root * @param {boolean} withLazy - Whether or not initialize component which marked as lazy */ - init(root = document.body, withLazy = true) { + init(root, withLazy = true) { + if (!(root instanceof HTMLElement)) { + console.error(`Can not initialize components in ${root}. The first argument must be an HTMLElement`); + return; + } + this._registredComponents.forEach(({ componentClass, selector }) => { this._initComponent(root, componentClass, selector, withLazy); }); From 9a3ce74cd07ebc6037a6212a98abe0dc365db6fa Mon Sep 17 00:00:00 2001 From: Maksim Kadomtsev Date: Wed, 3 Jun 2020 15:35:38 +0500 Subject: [PATCH 2/2] 3.0.0-0 --- package-lock.json | 2 +- package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/package-lock.json b/package-lock.json index f7a4014..6ba12ed 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,6 +1,6 @@ { "name": "@deleteagency/dc", - "version": "2.0.2", + "version": "3.0.0-0", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/package.json b/package.json index 720048f..5c20d83 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@deleteagency/dc", - "version": "2.0.2", + "version": "3.0.0-0", "description": "", "main": "src/index.js", "files": [