Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Delwaq CI #1668

Closed
visr opened this issue Jul 29, 2024 · 3 comments · Fixed by #1694
Closed

Fix Delwaq CI #1668

visr opened this issue Jul 29, 2024 · 3 comments · Fixed by #1694
Assignees
Labels
CI/CD Continuous Integration/Continuous deployment v1.0 Release!

Comments

@visr
Copy link
Member

visr commented Jul 29, 2024

I hoped #1664 would fix it, but it did not.
#1649 may also be related.
Delwaq seems to segfault, so not really a helpful error there.

@visr visr added the CI/CD Continuous Integration/Continuous deployment label Jul 29, 2024
@deltamarnix
Copy link
Contributor

The error that I see is QGIS plugin manager breaking down because it cannot decode some character. I think we should not install QGIS and its plugins for testing DELWAQ.

@Jingru923
Copy link
Contributor

Jingru923 commented Jul 31, 2024

I tried to run without QGIS plugin by pixi run install-ci, the pipeline returns error during unit testing

Pixi task (delwaq in dev): pytest python/ribasim/tests/test_delwaq.py

If digging deeper, there is this error: forrtl: severe (157): Program Exception - access violation
This might be that delwaq trying to access a location on teamcity that is not accessible, or delwaq code is broken and fail the unit tests. We should try to run delwaq locally and see if it's still error free

For more information on the error, you can look into the TC build on the branch fix-dw-ci

@visr visr added the v1.0 Release! label Aug 1, 2024
@evetion
Copy link
Member

evetion commented Aug 5, 2024

Had a nice investigation with @mKlapwijk about this. Turns out that newer Delwaq versions crash on logging to screen in specific cases (ours, and laptop, but not on their TC projects!): https://issuetracker.deltares.nl/browse/DELWAQ-881. For now, I'll revert to an older Delwaq version, we can expect that the next (weekly) pinned build of Delwaq has workarounded/fixed this issue.

@evetion evetion linked a pull request Aug 5, 2024 that will close this issue
@visr visr closed this as completed in #1694 Aug 5, 2024
@visr visr closed this as completed in 3bf29a6 Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Continuous Integration/Continuous deployment v1.0 Release!
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants